On 01/30/2015 11:21 AM, Penta, Sashi Kumar wrote:
> Hi John,
> 
> Please find my comments inlined below.
> 
> 
> *         What about OC_ALL?  That seems to be inconsistent with your 
> explanation.
> 
> * ****** With current code base, OC_ALL covers only ETHERNET and WIFI, 
> because BLE/EDR are not supported in all the platforms (e.g. Ubuntu).
> 
> *         Is it expected that I will eventually be able to do a single 
> FindResource on multiple networks?  I think I heard you say that.
> 
>>>>>>>>> Yes.
> 
> *         Is it expected in the meantime that I might do multiple 
> FindResource calls, each on a different network?
> 
>>>>>>>>> Yes and No.
> 
> *         No, You can send one findResource request on all interfaces (today 
> it is  WIFI and ETHERNET) using OC_ALL.


I just want to highlight an issue here that is orthogonal to the
bitfield/mask proposal.

The OCConnectivityType enum has one member, OC_ALL, that appears to be
different from the others. Normally I would expect the declaration of
such enums to explicitly assign the _ALL member a higher value in order
to reserve some space for additional values to be added later.

If OC_ALL does not fall into such a special category, then perhaps it
should be renamed.


--
Jon A. Cruz
jonc at osg.samsung.com

Reply via email to