The patch didn't break the build at all, is Things Manager not building as a part of our build system? It seemed like a partially implemented function that didn't really accomplish anything, and that no one was using (as far as we could tell at the time).
I'd be OK with reverting the patch if it is still in use (though it'll take a rebase), though I'm concerned that it took this long for it to come to light... Additionally, from looking at the code, it seems that the purpose is to just have a context to a resource object, which can be dealt with via std::bind on the EntityHandler. On Fri, 2015-06-12 at 02:25 +0900, ???(Uze Choi) wrote: > Things Manager uses it. > > Function Internally host parameter is processed. > > > > BR, Uze Choi > > From: Lenahan, Charlie [mailto:charlie.lenahan at intel.com] > Sent: Friday, June 12, 2015 1:23 AM > To: ???(Uze Choi); Keane, Erich > Cc: iotivity-dev at lists.iotivity.org > Subject: Re: [dev] Sudden Function removal for Group Management. > > > > > How was it referenced. The internal structure that had it wasn?t > exposed anywhere. > > > > > > There is a change https://gerrit.iotivity.org/gerrit/#/c/1042/ that > adds a callback parameter to CreateResource. > > > Would that be a better fit? > > > > > > Charlie Lenahan | Software Engineer | Intel Corporation | 322 West > Main Street | Louisville, KY 40202 | W - 502.963.0917 | 8-963.0917 > charlie.lenahan at intel.com | CDG ? WINS ? WSS EAST > | http://www.linkedin.com/in/charlielenahan > > > > > > From: "??? (Uze Choi)" <uzchoi at samsung.com> > Date: Thursday, June 11, 2015 at 3:48 AM > To: "Keane, Erich" <erich.keane at intel.com> > Cc: "iotivity-dev at lists.iotivity.org" > <iotivity-dev at lists.iotivity.org> > Subject: [dev] Sudden Function removal for Group Management. > > > > > > Charlie/Morrow/Erich > > > > From the https://gerrit.iotivity.org/gerrit/#/c/1143 change, > CreateResourceWithHost() function has been removed. > > Commit comment says, ?host member is never referenced anywhere? but, > it is definitely referenced from the Primitive service. > > Furthermore, this is the essential function for the Group Management > feature which is officially published release feature. > > > > Due to the removal of it, Group related function does not work > anymore. > > I was upset when this was removed and submitted even Morrow commented > that this function had been implemented from Samsung folk. > > > > I wish you guide us what should we do enable it again. > > > > BR, Uze Choi > >
