On 06/15/2015 11:10 AM, Rees, Kevron wrote: > Whether or not they are enabled by default is a different issue. I > don't care if they are enabled by default. I only care that I can > disable them. Currently I can't disable them from being built. This > means that I cannot avoid the extra dependencies the tests bring in. > To work around this, I have to patch scons like this:
So I think there are two different issues here. First issue is tests requiring extra dependencies that the main code does not. Follow-ups would be to look into the details of the dependencies. These perhaps should not be required, could be checked for at configure time, etc. The second issue is disabling build of the unit tests altogether. That appears to be what the patch does (and is quite different from the first issue). This really should not be done as it is a code-safety issue. Many of the same general reasons for using Gerrit and requiring all changes to get reviewed before committing apply here. If you work with TEST=0 causing unit tests to not be built, it is quite easy to accidentally break them and not notice. For the latter case we do have Jenkins running with configurations that should catch broken tests, but that starts to suck resources that could have be avoided by catching theses issues at the developer's desk well before they commit. So to sum up, it appears you asked a "how do I do such-and-such" without covering the "why I want to do such-and-such". If you are asking due to the first issue (which your later mail seems to indicate) then the proper solution would probably be for us to fix the broken tests so that building all tests won't need to be disabled. -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group jonc at osg.samsung.com
