For those samples, we validated that everything that is part of the build-scripts built correctly. It seems that these samples aren't part of the build-system, thus I don't believe we can force people to know of all of these.
In addition, new contributors (and single contributors) cannot be expected to fix changes in this many places without a good index of where they are. I see you submitted a handful of fixes for these, and I appreciate it, but if you could make these part of the build system, we can be assured that they will at least build in the future. Thanks, Erich On Wed, 2015-06-17 at 04:26 +0000, ??? wrote: > Dear John Light > > > > CA sample app for all platforms is not working now > > after "IP address plumbing changes to support IPv6" is merged in > master branch. > > > > CA sample app code is also included in OIC OpenSource. > it means User can use it. > > > > so. i think you should have tested whether CA Sample is working or > not. > since you had changed some CA API. > > unfortunately you didn't it. > > > > please test it next time. > > > > thank you > > > > Regards, > > Jihwan > > > > ------- Original Message ------- > > Sender : Gerrit Code Review<gerrit at iotivity.org> > > Date : 2015-06-17 05:04 (GMT+09:00) > > Title : Change in iotivity[master]: IP address plumbing changes to > support IPv6 > > > > From Sachin Agrawal : > > Sachin Agrawal has posted comments on this change. > > Change subject: IP address plumbing changes to support IPv6 > ...................................................................... > > > Patch Set 64: Code-Review+2 > > Merging to master. > > -- > To view, visit https://gerrit.iotivity.org/gerrit/1081 > To unsubscribe, visit https://gerrit.iotivity.org/gerrit/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I539879aeeb5aeddf2b136d81fdf1247c2af12b5f > Gerrit-PatchSet: 64 > Gerrit-Project: iotivity > Gerrit-Branch: master > Gerrit-Owner: John Light > Gerrit-Reviewer: Abhishek Pandey > Gerrit-Reviewer: Ashok Babu Channa > Gerrit-Reviewer: Doug Hudson > Gerrit-Reviewer: Erich Keane > Gerrit-Reviewer: Hyuna Jo > Gerrit-Reviewer: Jaehong Jo > Gerrit-Reviewer: Jaewon Kim > Gerrit-Reviewer: John Light > Gerrit-Reviewer: Joseph Morrow > Gerrit-Reviewer: Mandeep Shetty > Gerrit-Reviewer: MyeongGi Jeong > Gerrit-Reviewer: Naga Ashok Jampani > Gerrit-Reviewer: Sachin Agrawal > Gerrit-Reviewer: Thiago Macieira > Gerrit-Reviewer: jenkins-iotivity > Gerrit-Reviewer: jihwan seo > Gerrit-HasComments: No > > > > > > > > > > > _______________________________________________ > iotivity-dev mailing list > iotivity-dev at lists.iotivity.org > https://lists.iotivity.org/mailman/listinfo/iotivity-dev
