John and Ashok,
I am not a big fan of the situation, but our kitchen is too small for all the cooks. It looks like John addressed the same issues that you have as part of his IPv6 work. If I accept this your change set, it will set him back a couple days. This is same situation that we had with bringing the connectivity abstraction into master. As I tried to clear a path for connectivity abstraction I now have to clear a way for IPv6 and on a shorter schedule. There is an expectation that IPv6 will be available for the next plug-fest with a code freeze on June 2nd. This may have been possible at one time, but the delays (rebasing, etc.) are not going to make this possible and I need to reset expectations. Regarding proposals, John?s proposal have been in Jira for a long time: <https://jira.iotivity.org/browse/IOT-509> IOT-509, <https://jira.iotivity.org/browse/IOT-477> IOT-477, <https://jira.iotivity.org/browse/IOT-475> IOT-475, <https://jira.iotivity.org/browse/IOT-476> IOT-476, etc. Although, I searched the reflector history and did not find a mention of these references. I scan the Jira tickets 1-2 times a week so I was aware and John sent me email on the 475, 476 and 477 back in April. I have two issues here, this merge conflict and this issue moving forward. First, I need John and Ashok to align on the commit. To that end, John, When can you have your change set that address the same issues ready? Ashok can you quickly review John?s commit to make sure that it addresses any issues that you have? If it does not, Erich and I will pick. Second, in the connectivity space please give the reflector a heads up on your up coming contributions. There is little that I hate worse than a good faith effort thwarted and wasted by duplication and last-minute merge conflicts. Pat From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of ASHOKBABU CHANNA Sent: Tuesday, May 05, 2015 11:07 PM To: Light, John J; iotivity-dev at lists.iotivity.org Subject: Re: [dev] patch to eliminate all "singlethread" source files in IoTivity Dear John, Connectivity abstraction supports 4 platforms ? Android, Tizen, Ubuntu and Arduino, with multiple adapters (BT, BLE). Your changes need to be compiled and tested ( basic features) on supported platforms before merging it to master. And your new changes are already in the progress with following gerrits 1) <https://gerrit.iotivity.org/gerrit/#/c/783/8> https://gerrit.iotivity.org/gerrit/#/c/783/8 - single thread file removal (pushed on Apr20th) 2) <https://gerrit.iotivity.org/gerrit/#/c/752/> https://gerrit.iotivity.org/gerrit/#/c/752/ - single ip adapter for WIFI and Ethernet(pushed on Apr15th) We are handling changes incrementally as multiple platforms are involved. Your commit, make conflicts with 5 other patch sets and all contributors need to rebase the code and test it again for BT and BLE. (If you did not test your changes , it will creates more effort) To avoid these kind of problem, working groups are requesting proposals first before starting implementations. If you want to contribute, please make a proposal first or at least create a discussion in developers group(like glib discussion) Pat, Could you guide how we are going to handle this situation? Some developers may want to contribute in one platform but it will create issues in other platforms and features. I think handling with proposals first at least make sure people aware of the situation. Regards, Ashok ------- Original Message ------- Sender : Light, John J<john.j.light at intel.com <mailto:john.j.light at intel.com> > Date : May 02, 2015 05:05 (GMT+09:00) Title : [dev] patch to eliminate all "singlethread" source files in IoTivity I pushed to Gerrit a patch 876 which eliminates all ?_singlethread? files, responding to JIRA IOT-509. These files represent a significant fraction of technical debt IoTivity has accrued. My interest in doing this is my concern about applying IPv6 to them. I decided it would be easier to eliminate them than to deal with them. I started this on Monday. IOT-509 provides the technical approach used. Here are some stats. * 43 files affected. * 27 files with substantial changes. * 17 ?_singlethread? files deleted. * 6122 lines changed. * 381 lines support the new single thread paradigm. * 450 lines are mods to Ethernet and Wifi linux ?server? code to allow testing and debugging on Ubuntu. * 5390 lines are from the 17 deleted files. Of course, this required no changes to API or any other externally visible part of IoTivity. I?m sure the performance is no worse than the previous single thread solution. (I suspect the performance is indistinguishable from multithread performance.) I made no changes to multi-threaded operation. The only problem at this point is that Jenkins reports that it fails to build on Arduino because of an include file problem, which I suspect someone with an Arduino environment could find a fix in five minutes. No change was made to Arduino code. If we push this to master quickly, it will save lots of work for everybody. While Gerrit shows conflicts with five other patch sets, I suspect the collisions are tiny and can be resolved easily. John Light Intel OTC OIC Development <http://ext.samsung.net/mailcheck/SeenTimeChecker?do=fe69aed3ab8a86cad3ac768e7470b54e3b0d0c0811d73212a1889aa8efbbee4713d69ea60670f66e1fac5bf6c61543587bc8a6096cfbfc9f02e038c8d853bffbdb9fdddda33e82cbe4a391424e62fcf6cf878f9a26ce15a0> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150506/7f76177a/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.gif Type: image/gif Size: 13168 bytes Desc: not available URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150506/7f76177a/attachment.gif> -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 7198 bytes Desc: not available URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150506/7f76177a/attachment.p7s>
