Abhishek, The patchset submitted for IOT-733 does changes nothing. If line 2574 is executed, requestInfo.info == requestData which makes the changes in line 2594-2597 the same as before. If line 2574 is NOT executed, nothing is allocated. What am I missing? IOT-733 was root caused by a double free in the routing code and now ticket https://jira.iotivity.org/browse/IOT-739 is the result of the free of memory that was not malloc'ed. Pat
From: ABHISHEK PANDEY [mailto:[email protected]] Sent: Thursday, September 24, 2015 11:20 AM To: Lankswert, Patrick; Macieira, Thiago; iotivity-dev at lists.iotivity.org Subject: Re: Re: [dev] Discovery mechanism broken Hi Pat, [I am responding collectively for some concerns related to routing manger in this thread here, in addition to response already provided by MJ and Thiago.] [For QA Verification] AS MJ informed Samsung SQA team is testing this feature. Internally also we have done many rounds of developer testing before submitting this feature and as well as doing continuous verification on latest merged code in master. [For Spec Violation and Overhead due to routing manager] Regarding making this feature optional, we had provided ROUTING=OFF option initially, but during code review discussions we agreed to remove it (as I pointed out earlier). Even now in current situation ROUTING=EP option just enables IoTivity stack to handle messages with having routing header option. As Thiago pointed out earlier in thread, it does not violate the Spec. Regarding, memory overhead, difference is minimal for ROUTING=EP (just message parsing) and ROUTING=GW option which enables most of routing manager functionality remains optional. Regarding your comments on routing manager making the stack unstable, I don't agree for it to be true. The discovery issue earlier attributed to RM, was turned out to be bug in security code. We also analyzed problem reported in another JIRA issue - https://jira.iotivity.org/browse/IOT-733 and could not find anything wrong with RM handling. A fix for this is also submitted (in ocstack.c) for this gerrit review - https://gerrit.iotivity.org/gerrit/#/c/3045/. If any more issues are found, please let us know and we will check them on case by case basic. -- Thanks and Regards, Abhishek Pandey. ------- Original Message ------- Sender : Lankswert, Patrick<patrick.lankswert at intel.com<mailto:patrick.lankswert at intel.com>> Date : Sep 24, 2015 01:07 (GMT+05:30) Title : Re: [dev] Discovery mechanism broken Thiago, One of my obligations is to deliver a specification compliant stack. The routing manager is not based on any standard that I am aware of. We are free to add anything to iotivity, but to meet the standards-based obligation, I need to be able to build a version of the core framework that adheres to the standard. Adding non-standard options from within the stack is a problem. In the design discussions, it was said expressly that the routing manager features would be optional. So, what was promised was not delivered. It looks like a number of new issues in the stack are a result of the routing manager feature which was not a required feature, but now threatens the delivery of v1.0. Abhishek, Do we have a test plan for the routing manager and have you done a full regression of the stack from the SDK layer to validate this code base? Pat > -----Original Message----- > From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces > at lists.iotivity.org> [mailto:iotivity-dev- > bounces at lists.iotivity.org<mailto:bounces at lists.iotivity.org>] On > Behalf Of Thiago Macieira > Sent: Tuesday, September 22, 2015 12:25 PM > To: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at > lists.iotivity.org> > Subject: Re: [dev] Discovery mechanism broken > > On Tuesday 22 September 2015 14:22:18 Lankswert, Patrick wrote: > > Abhishek, > > > > Then why provide an option for ROUTING=OFF in the first place? > > That option was removed. > > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center > > _______________________________________________ > iotivity-dev mailing list > iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> > https://lists.iotivity.org/mailman/listinfo/iotivity-dev _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev [cid:image001.gif at 01D0F6BB.FDF7D820] [http://ext.samsung.net/mailcheck/SeenTimeChecker?do=36652d682e3669a8a817e1d25453775e224f423c0641e950980e0125dee6fd9fd3d52e3ddee9306ded04226648eb720dce7100ee954f3d131b20909a04efd4d2748cfe1d4e847419cf878f9a26ce15a0] -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150924/613bdee0/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.gif Type: image/gif Size: 13168 bytes Desc: image001.gif URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150924/613bdee0/attachment.gif>
