It does seem that this could be converted to a const pointer without any
issues.  The 'savedPlatformInfo' (saved in savePlatformInfo) gets copies
of everything, and the validatePlatformInfo ALSO takes it as a copy.

I'll note that SetDeviceInfo has this same issue, so you may wish to
convert that as well, to make them match.

Also, the C++ stack and the Java stack seem to have the same issue, so
converting this will likely cause a bit of trouble getting this to
compile across platforms.  

This would be an API breaking change, though I suspect that it is a good
change to make.  A bunch of samples and tests will need updating,b ut it
should not be all that involved of a change.

-Erich

On Wed, 2015-09-30 at 16:22 +0000, Light, John J wrote:
> I was surprised to discover that SetOCPlatformInfo (API) and all
> subsequent calls in the stack pass OCPlatformInfo by value.  It
> consists of 11 pointers.
> 
>  
> 
> I submitted this as JIRA-766.
> 
>  
> 
> If we should want to fix this embarrassing lapse for 1.0.0, I am
> willing to provide a patch.
> 
>  
> 
> John Light
> 
> Intel OTC OIC Development
> 
> 
> _______________________________________________
> iotivity-dev mailing list
> iotivity-dev at lists.iotivity.org
> https://lists.iotivity.org/mailman/listinfo/iotivity-dev

Reply via email to