Maybe a day or so. That's when I added a cancel handle and select(). It also took a little more since transports were still split into foo.*/foo_singlethread.* duplicates.
On 09/30/2015 12:47 PM, Lankswert, Patrick wrote: > Jon, > > How much work was it the first time? > > Pat > >> -----Original Message----- >> From: Jon A. Cruz [mailto:jonc at osg.samsung.com] >> Sent: Wednesday, September 30, 2015 2:20 PM >> To: Lankswert, Patrick; uzchoi at samsung.com; Agrawal, Sachin >> Cc: iotivity-dev at lists.iotivity.org >> Subject: Re: [dev] Jenkins for iotivity unit tests build timeout >> >> We used to have a 2000ms delay in the same context. I corrected that >> instance, >> but a different transport introduced a 4000ms one. >> >> It comes when creating an instance of the stack. Addressing the new delay the >> same way the old one was fixed should bring things back from several minutes >> down to just perhaps tens of seconds. >> >> >> On 09/30/2015 06:36 AM, Lankswert, Patrick wrote: >>> Uze, >>> >>> Most of the unit tests take 1-4ms. However, there is an entire block of >>> tests >> that are taking a little over four seconds a piece. Are these really unit >> tests? It >> looks like these tests need addressing before we break them out. >>> >>> Pat >>> >>> From: ???(Uze Choi) [mailto:uzchoi at samsung.com] >>> Sent: Wednesday, September 30, 2015 7:08 AM >>> To: Lankswert, Patrick; Agrawal, Sachin >>> Cc: iotivity-dev at lists.iotivity.org; Othman, Ossama; >>> minjii.park at samsung.com; ???; Trevor Bramwell >>> Subject: RE: [dev] Jenkins for iotivity unit tests build timeout >>> >>> Dear Maintainers. >>> >>> Currently all unit tests cannot be executed due to time limit.We It >>> will be better to increase the unit test limit time to secure the quality. >>> >>> For this one, I suggest to separate the unit test job into resource >>> one and service one according to the current directory structure, and to Add >> the new Jenkins task for service unit test. >>> >>> BR, Uze Choi >>> From: Othman, Ossama [mailto:ossama.othman at intel.com] >>> Sent: Tuesday, September 29, 2015 12:38 AM >>> To: minjii.park at samsung.com<mailto:minjii.park at samsung.com> >>> Cc: >>> iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org >>>> ; ???; Patrick Lankswert >>> Subject: Re: [dev] Jenkins for iotivity unit tests build timeout >>> >>> Hi Minji, >>> >>> On Mon, Sep 28, 2015 at 2:28 AM, minji park >> <minjii.park at samsung.com<mailto:minjii.park at samsung.com>> wrote: >>> >>> I tried to make IoTivity Jenkins verify unit tests for both resource >>> and service, >>> >>> but Jenkins build for unit tests is aborted due to the timeout (after 7 or >>> 8 mins). >>> >>> To execute all unit tests, it takes more than 8 minutes. >>> >>> To verify both resource and service unit tests at Jenkins build time, It >>> seems >> that discussion regarding time limit for unit tests is needed. >>> Part of the long test run times for the Linux builds is due to timed >>> condition >> variable waits in the Linux BLE Transport that block waiting for a Bluetooth >> adapter to be found/enabled. The timed waits are being triggered in the >> Jenkins >> build since no usable Bluetooth adapter is available. I have a patch >> pending that >> should alleviate the test timeout problem. >>> >>> Thanks, >>> -Ossama >>> >>> >>> >>> _______________________________________________ >>> iotivity-dev mailing list >>> iotivity-dev at lists.iotivity.org >>> https://lists.iotivity.org/mailman/listinfo/iotivity-dev >>> >> >> -- >> Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group >> jonc at osg.samsung.com -- Jon A. Cruz - Senior Open Source Developer Samsung Open Source Group jonc at osg.samsung.com
