On Aug 19, 2016 1:45 PM, "Mats Wichmann" <m.wichmann at samsung.com> wrote: > > Hijacking this thread (which was on OCF oswg list) to ask an IoTivity question... > > > On 08/18/2016 09:29 AM, Thiago Macieira wrote: > > Hello Richard > > > > https://wiki.iotivity.org, the coding style should be there. > > Are there any guidelines beyond the actual code contents style? > > I know it has to be verified by Jenkins before being eligible to be merged. > > How about warnings? The current full build has a lot of warnings, ranging from the relatively harmless (parameter set but unused), to the trivial to fix (missing include: implicit function declaration) to potentially troubling (passing argument from incompatible pointer type, making integer from pointer). There's presumably not a policy that "all warnings should be eliminated". [Aside: a good chunk of the warnings are from extlibs stuff, which would be a pain to pursue from inside iotivity, so a blanket prohibit on warnings is not necessarily feasible] >
While we're at it, how about the code in the build system? It's code; it's essential; it deserves the same fastidious care and feeding as c/c++ code. But with all due respect what's there now is pretty appalling (IMHO). -gregg > etc. > > Is stuff like this recorded somewhere? > > On quarta-feira, 17 de agosto de 2016 22:51:52 PDT Chow, Richard wrote: > >> Hi, > >> > >> The Security Working Group is looking into providing some secure coding > >> guidelines/practices to IoTivity. To that end, could somebody point me to > >> recommended coding guidelines or a release checklist for IoTivity > >> developers? > >> > >> Thanks, > >> Richard > > _______________________________________________ > iotivity-dev mailing list > iotivity-dev at lists.iotivity.org > https://lists.iotivity.org/mailman/listinfo/iotivity-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160819/163d96be/attachment.html>
