On sexta-feira, 10 de junho de 2016 14:55:44 PDT Gregg Reynolds wrote: > On Fri, Jun 10, 2016 at 2:45 PM, Thiago Macieira <thiago.macieira at > intel.com> > wrote: > > On sexta-feira, 10 de junho de 2016 10:03:13 PDT Mats Wichmann wrote: > > > On 06/10/2016 09:50 AM, Gregg Reynolds wrote: > > > > The current build structure clashes somewhat with scons (and other) > > > > conventions. In particular, site_scons/, site_scons/site_init.py, and > > > > site_scons/site_tools are expressly designed to manage the kind of > > > > stuff > > > > > > that is currently scattered about the codebase, such as > > > > build_common/iotivityconfig, build_common/external_libs.scons, > > > > tools/scons, etc. > > > > > > > > I've pushed a draft changeset as a first step in moving to a more > > > > standardized structure: > > > > > > > > https://gerrit.iotivity.org/gerrit/#/c/8597/ > > > > > > > > I'm not really sure how drafts work. Do they not get the Jenkins > > > > treatment? Are they visible? > > > > > > not visible to me, in any case. > > > > > > Code Review - Error > > > The page you requested was not found, or you do not have permission to > > > > view > > > > > this page. > > > > Hi Gregg > > > > Just make them public (non-draft) state, so everyone can look at it. > > Hi Thiago, > > How do I do that? Click the "Publish" button?
Yes. As a rule of thumb, I recommend not to use the draft feature. Hiding code is usually not a good idea. If you want to let people know that it shouldn't be merged, vote -1 yourself or start the commit message with "WIP" (work in progress) or "DO NOT SUBMIT". > The reason I made it a draft is because it seems like a fairly major change > that should be discussed. Maybe I'm not understanding the purpose of > Drafts. Probably. It's kind of a misfeature, in my opinion. You can use it to push things that you want to discuss with a very restricted set of people. If you post about it to the mailing list, though, it's not very restricted. Let everyone see it. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center
