Obviously we should try to keep the number, complexity and size of optional/experimental features at a minimum.
When we really have to add optional features, we should try harder to add appropriate check-in verification test coverage in Jenkins. For example: we don?t seem to have enough test coverage for SECURED=1. I bet there are other optional features that also don?t have adequate test coverage either. Also, hopefully we can design smaller/better extension points for optional features, and move more of the optional code into separate source code modules, and possibly separate LIBs. Hopefully we can avoid that way most of the time adding ~100 lines of #ifdef code in the middle of a non-optional function, etc. Dan From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of Dave Thaler via iotivity-dev Sent: Wednesday, November 16, 2016 1:40 AM To: uzchoi at samsung.com; iotivity-dev at lists.iotivity.org Subject: Re: [dev] [suggestion] RE: Change in iotivity[master]: fix findresource failure issue. In general it?s better to factor code out so there are no ifdefs inline. This obviously takes more work, but is where I think we need to move over time, i.e. to refactor code to remove ifdefs rather than continually adding more. The challenge though is with optional/experimental features which are sometimes harder to factor than say platform-specific ifdefs. From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [mailto:[email protected]] On Behalf Of ??? Sent: Wednesday, November 16, 2016 5:17 PM To: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: [dev] [suggestion] RE: Change in iotivity[master]: fix findresource failure issue. Hi IoTivity, On the source code, there are lots of #ifdef code, Maintanence and behavior consistency view, it is very risk. Especially, on the common base code, I prefer not to use it as much as possible. Any suggestion to remove this kind of issue? BR, Uze Choi --------- Original Message --------- Sender : Habib Virji (Code Review) <gerrit at iotivity.org<mailto:gerrit at iotivity.org>> Date : 2016-11-16 17:09 (GMT+9) Title : Change in iotivity[master]: fix findresource failure issue. Habib Virji has posted comments on this change. Change subject: fix findresource failure issue. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.iotivity.org/gerrit/14397 To unsubscribe, visit https://gerrit.iotivity.org/gerrit/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70314bdc6506101b551c9389bb694cad3bf222f5 Gerrit-PatchSet: 1 Gerrit-Project: iotivity Gerrit-Branch: master Gerrit-Owner: jihwan seo <jihwan.seo at samsung.com<mailto:jihwan.seo at samsung.com>> Gerrit-Reviewer: Ashok Babu Channa <ashok.channa at samsung.com<mailto:ashok.channa at samsung.com>> Gerrit-Reviewer: Dave Thaler <dthaler at microsoft.com<mailto:dthaler at microsoft.com>> Gerrit-Reviewer: Habib Virji <habib.virji at samsung.com<mailto:habib.virji at samsung.com>> Gerrit-Reviewer: JungYong KIM <jyong2.kim at samsung.com<mailto:jyong2.kim at samsung.com>> Gerrit-Reviewer: Larry Sachs <larry.j.sachs at intel.com<mailto:larry.j.sachs at intel.com>> Gerrit-Reviewer: MyeongGi Jeong <myeong.jeong at samsung.com<mailto:myeong.jeong at samsung.com>> Gerrit-Reviewer: Uze Choi <uzchoi at samsung.com<mailto:uzchoi at samsung.com>> Gerrit-Reviewer: jenkins-iotivity <jenkins-iotivity at opendaylight.org<mailto:jenkins-iotivity at opendaylight.org>> Gerrit-HasComments: No [cid:image001.gif at 01D23FEF.90058460] [http://ext.samsung.net/mail/ext/v1/external/status/update?userid=uzchoi&do=bWFpbElEPTIwMTYxMTE2MDgxNzAzZXBjbXMxcDEzZjc3ZjRiMjU3ZDEwYTM2NzYyYzcyMGNmMjY5MjlhNCZyZWNpcGllbnRBZGRyZXNzPWlvdGl2aXR5LWRldkBsaXN0cy5pb3Rpdml0eS5vcmc_] -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20161116/f9fb3bd4/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.gif Type: image/gif Size: 13402 bytes Desc: image001.gif URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20161116/f9fb3bd4/attachment.gif>
