Yes, not only is the code IPv4-biased, but it's also broken in that it doesn't distinguish between IPv4 and IPv6. So if an IPv6 address is first, it won't add any IPv4 entry.
From: Paul Duffy [mailto:[email protected]] Sent: Friday, October 7, 2016 9:57 AM To: Dave Thaler <dthaler at microsoft.com>; jihwan.seo at samsung.com; Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org> Subject: Re: [dev] CAInterface_t question "only creates one entry per interface" On 10/7/2016 12:37 PM, Dave Thaler wrote: What's "it"? CAEndpoint_t's address isn't just for IPv4 since the eps value in /oic/res will need to return entries with IPv6 addresses. From: Paul Duffy [mailto:[email protected]] Sent: Friday, October 7, 2016 9:32 AM To: Dave Thaler <dthaler at microsoft.com><mailto:dthaler at microsoft.com>; jihwan.seo at samsung.com<mailto:jihwan.seo at samsung.com>; Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org><mailto:iotivity-dev at lists.iotivity.org> Subject: Re: [dev] CAInterface_t question Seems like it is IPv4 biased. On 10/7/2016 12:11 PM, Dave Thaler via iotivity-dev wrote: I looked in caipserver.c and it appears there that you are correct, that each CAInterface_t results in a CAEndpoint_t, and hence CAInterface_t is confusingly misnamed. However, this also means that there are bugs in various places. If you look in ip_adapter\linux\caipnwmonitor.c for instance, CAIPGetInterfaceInformation() calls CACmpNetworkList() and only creates one entry per interface, not one per address or even one per address family. There are similar problems in other files. Dave From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [mailto:[email protected]] On Behalf Of ??? Sent: Friday, October 7, 2016 3:32 AM To: Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org><mailto:iotivity-dev at lists.iotivity.org> Subject: Re: [dev] CAInterface_t question My understand is that CAInterface_t is not mapping with interface you mentioned. The key of CAInterface_t is the address. not interface name. CA doesn't interest that structure as interface unit. probably, interface name member should be removed. because it's not used anything. And Since CAInterface_t name can be gaven some confusion. it should be replaced with other name. --------- Original Message --------- Sender : Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org>> Date : 2016-10-07 04:31 (GMT+9) Title : Re: [dev] CAInterface_t question Actually given the name of it, the best answer would be "1" since there's just one interface, with multiple CAEndpoint_t's on it. But that doesn't appear to be what the code is doing and I'm not sure why. I can't actually think of a reason to have more than 2 (one for IPv4, one for IPv6) since that's how many discovery requests you need to send, so I'm not sure why there's an addr field in the structure at all. Can someone explain? From: iotivity-dev-bounces at lists.iotivity.org<mailto:iotivity-dev-bounces at lists.iotivity.org> [mailto:[email protected]] On Behalf Of Dave Thaler via iotivity-dev Sent: Thursday, October 6, 2016 12:27 PM To: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: [dev] CAInterface_t question What is the intended granularity of this structure? Say you have a WiFi interface with 6 IP addresses: 1) An IPv4 address 2) An IPv6 link-local address 3) A public IPv6 address in subnet A 4) A public IPv6 address in subnet B 5) A temporary IPv6 address in subnet A 6) A temporary IPv6 address in subnet B How many CAInterface_t structures should you have? I'm guessing the correct answer is 4 (addresses 1-4 above), but if that's incorrect, please elaborate. Dave _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev [cid:image001.gif at 01D22084.DA702440] [http://v70ext.samsung.net/mail/ext/v1/external/status/update?userid=jihwan.seo&do=bWFpbElEPTIwMTYxMDA3MTAzMTQ0ZXBjbXMxcDNhZjY1NTcwNWNmNDQ5ZGM2NTFjYWE4OTcxMjQwYmUwNyZyZWNpcGllbnRBZGRyZXNzPWlvdGl2aXR5LWRldkBsaXN0cy5pb3Rpdml0eS5vcmc_] _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20161007/cbc357b6/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.gif Type: image/gif Size: 13402 bytes Desc: image001.gif URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20161007/cbc357b6/attachment.gif>
