You're welcome, I was a bit away from keyboard those past days, now I am fully back.
Note, there a few others that would be nice to have in too https://gerrit.iotivity.org/gerrit/#/c/12969/ https://gerrit.iotivity.org/gerrit/#/c/12893/ https://gerrit.iotivity.org/gerrit/#/c/12895/ https://gerrit.iotivity.org/gerrit/#/c/12965/ https://gerrit.iotivity.org/gerrit/#/c/12471/ Please everyone review 1.2 branch https://gerrit.iotivity.org/gerrit/#/q/status:open+project:iotivity+branch:1.2-rel+is:mergeable+AND+NOT+label:Code-Review%253D-1+AND+NOT+label:Verified%253D-1 Also, I will probably file a bug about our gerrit setup because it's not the 1st time we have this issue where patches are merged in a different order than they were submitted... in that case CI verify is inconstant. On Sat, Oct 15, 2016 at 6:29 AM, ??? <uzchoi at samsung.com> wrote: > Thank you for your answer Phil. > Once #12897 is verified by testing, let me re-tag RC4 on top of #12897. > > BR Uze Choi > ---------* Original Message* --------- > *Sender* : Philippe Coval <philippe.coval.pro at gmail.com> > *Date* : 2016-10-15 02:08 (GMT+9) > *Title* : Re: [dev] About Tizen Build failure issue in RC4 > > > > On Fri, Oct 14, 2016 at 3:58 PM, JiHwan Seo <jihwan.seo at samsung.com> > wrote: > >> Hi Phil. >> >> >> >> we got build failure issue for Tizen like below log. >> >> when we tried to build it with all service layer. >> >> [command] >> >> >./gbs_build.sh >> >> >> >> And found that the build is working fine after revert your patch ( >> https://gerrit.iotivity.org/gerrit/#/c/12891/) >> >> we think removing just this line should work >> > > Hi Jihwan Seo, > > Thanks for the notification, is the problem not trapped by CI ? > > I am unable to check now, but maybe you faced that problem > because my #12891 patch was merged before this change: > > https://gerrit.iotivity.org/gerrit/#/c/12897/ > > I will double check to make sure, see you on gerrit > > -- > -- > https://wiki.tizen.org/wiki/User:Pcoval > > > _______________________________________________ > iotivity-dev mailing listiotivity-dev at > lists.iotivity.orghttps://lists.iotivity.org/mailman/listinfo/iotivity-dev > > > > > -- -- https://wiki.tizen.org/wiki/User:Pcoval -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20161015/43ea1377/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 13402 bytes Desc: not available URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20161015/43ea1377/attachment.gif>
