These functions are intended to be part of the platform support layer. I sent emails to Jon some time ago (Sep 9th) and got no response, including a notice that if I didn?t hear any objections within another week, I would assume silence means ok to take over as maintainer since the point of these is not about connectivity but rather platform abstraction. So I merged as Platform Support maintainer after more than another week passed without any objection. The changes were out for code review for nearly 3 weeks so there was plenty of opportunity for comment. Dave From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of ??? Sent: Monday, September 19, 2016 8:37 PM To: Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org>; ??? <dongik.lee at samsung.com> Subject: Re: [dev] Request to revert the merged patches(#11227,#10743)
Hi Dave. I have a simple question. Why did you merge #11227, #10743? Since Jon.A.Cruz is a maintainer of Base Layer and Ashok is a sub-maintainer, I don't think, you can merge the codes without Jon's comment. I don't understand your position. I think the changes should have been merged by Jon or Ashok. Can you tell me you exact position? --------- Original Message --------- Sender : Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org>> Date : 2016-09-19 20:24 (GMT+9) Title : Re: [dev] Request to revert the merged patches(#11227,#10743) I don?t understand. Jenkins passed with both of these, and https://build.iotivity.org/ci/view/iotivity-merge/ shows that the merge builds also pass fine. From: ??? [mailto:[email protected]] Sent: Monday, September 19, 2016 8:07 PM To: Dave Thaler <dthaler at microsoft.com<mailto:dthaler at microsoft.com>> Cc: iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> Subject: Request to revert the merged patches(#11227,#10743) Dear Dave, After merging the below patches, the current iotivity scons build with SECURED=1 WITH_TCP=1 WITH_CLOUD=1 results in failure. build error happens with commit id fef945f09258318fc799210618c7115648df51b3 https://gerrit.iotivity.org/gerrit/#/c/11227/ https://gerrit.iotivity.org/gerrit/#/c/10743/ Compiling out/linux/x86_64/release/resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.os resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.c:30:21: fatal error: camutex.h: No such file or directory compilation terminated. scons: *** [out/linux/x86_64/release/resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.os] Error 1 Basically, the above options should be successful. I am wondering why jenkins build script does not reflect for the regarding option for now. Could you revert the above patches and upload patch again after jenkins build option has been updated ? BR, Dongik ________________________________ Dongik LEE (Principal Engineer) Security Lab.(Software R&D Center) SAMSUNG ELECTRONICS CO.,LTD Mobile : +82-10-5091-8190 E-mail : dongik.lee at samsung.com<mailto:dongik.lee at samsung.com> ________________________________ _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org> https://lists.iotivity.org/mailman/listinfo/iotivity-dev [cid:image001.gif at 01D212B6.CC0911E0] [http://v70ext.samsung.net/mail/ext/v1/external/status/update?userid=jihwan.seo&do=bWFpbElEPTIwMTYwOTE5MTEzNjU5ZXBjbXMxcDI3MmUyMDFhYmYwMWVhMzkxN2MzY2ZlZDA5YmMyYjBkYyZyZWNpcGllbnRBZGRyZXNzPWlvdGl2aXR5LWRldkBsaXN0cy5pb3Rpdml0eS5vcmc_] -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160919/b98ef6e7/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.gif Type: image/gif Size: 13402 bytes Desc: image001.gif URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160919/b98ef6e7/attachment.gif>
