Alright, I've reformatted the patch using git-format-patch. I've
attached it to this e-mail.
All the best,
Koenraad
On 4 April 2017 at 20:10, Philippe Coval <philippe.coval at osg.samsung.com>
wrote:
>
> On 04/04/17 18:14, Koenraad Verheyden wrote:
>>
>> Hi Phillipe,
>>
>> I've found that the libraries are built (libnotification_consumer.so
>> and libnotification_provider.so), but simply weren't copied over when
>> building the image. I've adapted the recipe to do this now.
>
> Thanks this is appreciated.
>>
>> I've created a patch file (see attached). Should I submit this on
>> Gerrit? (I'm new to working on larger existing projects)
>
> meta-oic is hosted on yocto.org see readme file in layer
> but forwarding to this list is fine.
>
> If you want you can send it again using git-send-email or
> git-format-patch, this way authorship will be preserved.
>
>> I've changed the following:
>> - Added some extra files for Easy Setup: includes and executables
>> related to the enrollee. (Files for the mediator are already present.)
>> - Added support for Notification service. This will copy libraries,
>> includes and samples similar to how Easy Setup is handled.
>
> For 1.3 maybe this should be done by sconscripts,
> to avoid doing this twice.
>>
>> I've mostly mirrored how Easy Setup is configured, so please check if
>> this makes any sense (especially for the tests, since I haven't used
>> those).
>>
>> With kind regards,
>> Koenraad
>>
>>
>>
>> diff --git a/recipes-core/iotivity/iotivity_1.2.1.bb
>> b/recipes-core/iotivity/iotivity_1.2.1.bb
>> index 344db21..9b2f13f 100644
>> --- a/recipes-core/iotivity/iotivity_1.2.1.bb
>> +++ b/recipes-core/iotivity/iotivity_1.2.1.bb
>> @@ -285,6 +285,7 @@ do_install() {
>>
>> #Easy setup app
>> make_dir ${IOTIVITY_BIN_DIR_D}/examples/service/easy-setup
>> + copy_exec
>> ${S}/out/yocto/${IOTIVITY_TARGET_ARCH}/release/service/easy-setup/sampleapp/enrollee/linux/enrollee
>> ${IOTIVITY_BIN_DIR_D}/examples/service/easy-setup
>>
> (...)
> This look good to me, Kishen might double check.
>
>
> --
> mailto:philippe.coval at osg.samsung.com gpg:0x467094BC
> https://blogs.s-osg.org/author/pcoval/
>
> _______________________________________________
> iotivity-dev mailing list
> iotivity-dev at lists.iotivity.org
> https://lists.iotivity.org/mailman/listinfo/iotivity-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-Notification-service-and-Easy-Setup-enrollee-r.patch
Type: application/octet-stream
Size: 4959 bytes
Desc: not available
URL:
<http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20170406/f5c425fe/attachment.obj>