Hi Mats, On Wed, May 31, 2017 at 11:04 AM, Mats Wichmann <mats at wichmann.us> wrote: > > One very specific question: > > there's a whole iotivityconfig directory with python modules in it, > which apparently used to do a fair bit of compiler detection work.
I introduced that compiler related detection code over two years ago after noticing that C++11 and C99 build flags were used in a rather ad hoc manner throughout many IoTivity Sconscript files. However, the Python calls that ran the compiler detection code were lost during the big connectivity branch merge back then, and were never reintroduced. Now > it looks like it wants to check whether there is POSIX thread > support, though the way this iotivityconfig module is imported it looks > like the other tests get run too (based on config.log), even if it > doesn't seem anything is done with the other results. > The pthreads check was added later on (see commit 2cdbf260), but I wasn't involved with that so I don't know much about it. Is there any reason to continue configure-checking for pthreads support? > Can't we just use what we know about the different platforms, just like > so many other decisions are wired in on this basis? The presence of > this check is step 1 behind blocking a bug I filed, IOT-2356. > Unless IoTivity starts leveraging automated feature/platform checks in a consistent manner, I don't see why not. HTH, -Ossama -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20170531/ff8082da/attachment.html>
