On 07/16/2018 12:42 PM, Ignacio Ocampo wrote: > Forwarding this message to the iotivity-dev@lists.iotivity.org distribution > list. > > On Mon, Jul 16, 2018 at 8:38 AM, Ignacio Ocampo <naf...@gmail.com> wrote: > >> Hi Seokhee, >> >> I just read the Project Governance, and it seems the question I have is >> more related to the *Platform Support* project. >> >> I saw Mac OS was supported but not anymore, I modified several SCons >> scripts (I didn't modify not code at all), to support Mac OS again. >> >> Please find attached the patch (git diff > patchForMacOSX.txt) I created >> with the changes, it is based on the 1.3.1 branch. >> >> I saw also it was supported for iOS, and despite the SCons changes I made >> could ve very similar for iOS, I didn't changed neither tested anything for >> iOS yet. >> >> I tested the following in Mac OSX (10.12.6): >> >> >> - scons SECURED=1 RELEASE=true BUILD_JAVA=true >> JAVA_HOME=`/usr/libexec/java_home -v 1.8` -j 8 >> - scons SECURED=0 RELEASE=true BUILD_JAVA=true >> JAVA_HOME=`/usr/libexec/java_home -v 1.8` -j 8 >> - scons SECURED=1 RELEASE=false BUILD_JAVA=true >> JAVA_HOME=`/usr/libexec/java_home -v 1.8` -j 8 >> - scons SECURED=0 RELEASE=false BUILD_JAVA=true >> JAVA_HOME=`/usr/libexec/java_home -v 1.8` -j 8 >> - I executed examples in C, with and without security. >> - I executed examples with Java (JNI). >> >> Could we review/discuss this changes?
I'll be supportive of this from the viewpoint of being the build maintainer which is where your changes are now; otherwise it would be great if we had a maintainer who covered the MacOS/iOS parts (Gregg touches on some of the additional things needed beyond just "it builds"). The best way to get a review going is to submit it to gerrit, the patch reviewing system. If you want to take your time getting used to how that works I can submit your current patch for you since you've already made one up patch - but I'd prefer to do it against master (we can cherry-pick to specific release branches later). There will be a bit of merging work (just in "if target_os in ... lines") since WebOS support has made it in since 1.3 was branched off. Some instructions are here: https://wiki.iotivity.org/submitting_to_gerrit -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9777): https://lists.iotivity.org/g/iotivity-dev/message/9777 Mute This Topic: https://lists.iotivity.org/mt/23534908/21656 Group Owner: iotivity-dev+ow...@lists.iotivity.org Unsubscribe: https://lists.iotivity.org/g/iotivity-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
