G'Day Evgenii,
On Fri, Feb 8, 2019 at 10:29 AM Evgenii Seliavka <[email protected]> wrote: > > Hello, > > I slightly changed tools/tcpaccept.py and enhance the script with the > possibility to track only connection which very dropped because of listen > queue overflow. Just want to know community opinion is this changes worth of > the PR on upstream/master, because bcc repo already contains tcpdrop.py? > Please find the patch in attachment. Tested this on kernel-4.14.74 and > kernel-4.18.0. As in CONTRIBUTING_SCRIPTS.md, we're after tools that do one thing and do it well, so I'd generally avoid adding features that didn't belong in tools. In this case, it might actually belong because you're looking at what we could call "accept failures". But I'm struggling to read your diff. Can you please regenerate with -u, and also there's a lot of churn: - event.task, event.ip, - inet_ntop(AF_INET6, event.daddr).encode(), - inet_ntop(AF_INET6, event.saddr).encode(), - event.lport)) + + fields = [event.pid, + event.task, + event.ip, + inet_ntop(AF_INET6, event.daddr).encode(), + inet_ntop(AF_INET6, event.saddr).encode(), + event.lport, + ] Changing many things at once makes it harder to understand the change you want us to look at. Brendan > > > -- > Best Regards, > Seliavka Evgenii > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1569): https://lists.iovisor.org/g/iovisor-dev/message/1569 Mute This Topic: https://lists.iovisor.org/mt/29704856/21656 Group Owner: [email protected] Unsubscribe: https://lists.iovisor.org/g/iovisor-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
