Revision: 5589
          http://ipcop.svn.sourceforge.net/ipcop/?rev=5589&view=rev
Author:   gespinasse
Date:     2011-04-04 06:03:47 +0000 (Mon, 04 Apr 2011)

Log Message:
-----------
Fix address and netmask concatenated on each network before ifconfig by 
replacing strcat with strcpy.
That could be seen on my test config with install codepath=1 (as I usually only 
use pxe)

I noticed that issue 23 month ago too but forgot

Modified Paths:
--------------
    ipcop/trunk/src/installer/installer.c

Modified: ipcop/trunk/src/installer/installer.c
===================================================================
--- ipcop/trunk/src/installer/installer.c       2011-04-03 15:56:14 UTC (rev 
5588)
+++ ipcop/trunk/src/installer/installer.c       2011-04-04 06:03:47 UTC (rev 
5589)
@@ -194,22 +194,22 @@
         fprintf(flog, "udhcpc SERVERID not found\n");
         return FAILURE;
     }
-    strcat(server_IP, find_kv(kv_dhcp_params, "SERVERID"));
+    strcpy(server_IP, find_kv(kv_dhcp_params, "SERVERID"));
     if (find_kv(kv_dhcp_params, "IP") == NULL) {
         fprintf(flog, "udhcpc IP not found\n");
         return FAILURE;
     }
-    strcat(local_IP, find_kv(kv_dhcp_params, "IP"));
+    strcpy(local_IP, find_kv(kv_dhcp_params, "IP"));
     if (find_kv(kv_dhcp_params, "NETMASK") == NULL) {
         fprintf(flog, "udhcpc NETMASK not found\n");
         return FAILURE;
     }
-    strcat(netmask, find_kv(kv_dhcp_params, "NETMASK"));
+    strcpy(netmask, find_kv(kv_dhcp_params, "NETMASK"));
     /* domain is not mandatory */
     if (find_kv(kv_dhcp_params, "DOMAIN") == NULL) {
         fprintf(flog, "udhcpc DOMAIN not found\n");
     } else {
-        strcat(domain, find_kv(kv_dhcp_params, "DOMAIN"));
+        strcpy(domain, find_kv(kv_dhcp_params, "DOMAIN"));
     }
     free_kv(&kv_dhcp_params);
     return SUCCESS;


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________
Ipcop-svn mailing list
Ipcop-svn@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipcop-svn

Reply via email to