Hi Gabriel, Here is the comment from Tim who addressed this. Thanks for pointing it out.
"According to the Automake manual man_MANS is for autogenerated manpages and dist_man_MANS is for distributed manpages. Since the iperf manual is static and distributed, it should only be in dist_man_MANS." The commit occurred per: http://sourceforge.net/p/iperf2/code/ci/a1d3ff4a06583438b4104762eb410f7e7b667770 Bob -----Original Message----- From: Gabriel L. Somlo [mailto:gso...@gmail.com] Sent: Friday, April 10, 2015 8:20 AM To: iperf-users@lists.sourceforge.net Subject: [Iperf-users] iperf 2.0.8 'make install' error Hi, I'm packaging iperf-2.* in Fedora, and in the process of upgrading to 2.0.8 (from the old 2.0.5) I noticed that 'make install' fails: ... Making install in man make[1]: Entering directory '/tmp/FOO/iperf-2.0.8/man' make[2]: Entering directory '/tmp/FOO/iperf-2.0.8/man' make[2]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/tmp/FOO/share/man/man1' /usr/bin/install -c -m 644 iperf.1 iperf.1 '/tmp/FOO/share/man/man1' /usr/bin/install: will not overwrite just-created ‘/tmp/FOO/share/man/man1/iperf.1’ with ‘iperf.1’ Makefile:292: recipe for target 'install-man1' failed make[2]: *** [install-man1] Error 1 ... The problem originates here (lines 256-257 of man/Makefile.in): man_MANS = iperf.1 dist_man_MANS = $(man_MANS) Then, the "install-man1" target attempts to install files from *both* man_MANS and dist_man_MANS, essentially ending up with "iperf.1 iperf.1" This happened in 2.0.5 as well, AFAICT, except now the makefile tries to be "smarter" and do it all from a single invocation of /usr/bin/install, whereas 2.0.5 used to invoke /usr/bin/install for each file, thus hiding the problem. For now, the patch below takes care of it for me. I'd much appreciate this (or something similar, only better in terms of canonical [auto]make kung-fu) being applied towards the upcoming 2.0.9 release ! Thanks much, --Gabriel diff -NarpU5 iperf-2.0.8/man/Makefile.in iperf-2.0.8.maninstall/man/Makefile.in --- iperf-2.0.8/man/Makefile.in 2015-04-02 16:51:48.000000000 -0400 +++ iperf-2.0.8.maninstall/man/Makefile.in 2015-04-10 10:56:22.284937446 -0400 @@ -289,11 +289,11 @@ $(ACLOCAL_M4): @MAINTAINER_MODE_TRUE@ $( cd $(top_builddir) && $(MAKE) $(AM_MAKEFLAGS) am--refresh $(am__aclocal_m4_deps): install-man1: $(dist_man_MANS) $(man_MANS) @$(NORMAL_INSTALL) @list1=''; \ - list2='$(dist_man_MANS) $(man_MANS)'; \ + list2='$(dist_man_MANS)'; \ test -n "$(man1dir)" \ && test -n "`echo $$list1$$list2`" \ || exit 0; \ echo " $(MKDIR_P) '$(DESTDIR)$(man1dir)'"; \ $(MKDIR_P) "$(DESTDIR)$(man1dir)" || exit 1; \ ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ Iperf-users mailing list Iperf-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iperf-users ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ Iperf-users mailing list Iperf-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iperf-users
