> From Darren Reed
> > Oops, things are even more complicated. Just as in Solaris 8, the older
> > patch levels of Solaris 7 do not contain this function, but the newer ones
> > do! Thus the SOLARIS2 value is not a useful criterion at all. There must
> > either be an automatic test or a hint how to manually modify (e.g.) the
> > Makefile.
> 
> I'm halfway tempted to say "if your kernel doesn't have it,
> update your installed patch set."  Is that being too harsh ?

I think so. But there may be an easier solution. Function miocpullup is
presently only used in one place in pfilstream.c. Thus, if the present
substitute definition works properly, one might move it from pfildrv.c
to the beginning of pfilstream.c, give it a different name (say, mymiocpup)
and define it as static. If desired, one might additionally wrap the
definition as follows (before the usage of mymiocpup):
#if SOLARIS2 > 8
#define mymiocpup miocpullup
#else
 /* Here the definition of mymiocpup */
#endif
Now, I am no more sure that it is required in Solaris 7 at all, since
its usage in pfilstream.c depends on #ifdef SIOCSLIFNAME, which seems
not to exist in /usr/include even with the most recent kernel patch.
If true, your change 2.1.1 -> 2.1.2 would not be incorrect for Solaris 7
but both versions would conflict with recent patch levels of Solaris 8,
whereas omitting the substitute definition would conflict with earlier
levels of Solaris 8 which have SIOCSLIFNAME but not miocpullup.
(I have not attempted to actually install the new pfil yet, just became
aware of these problems by looking at the differences from 2.1.1.)

Reply via email to