Thanks Sean, I'll follow the contribution process and we'll see what happens.
My current work in progress, a theme for the Vanilla forum software is up here: http://www.gingerbeardman.com/iphone/ Best, matt On Fri, May 9, 2008 at 7:18 PM, Sean Gilligan <[EMAIL PROTECTED]> wrote: > > Hi Matt, > > I don't have time to review your changes right now, but thanks for the > contribution. > > The preferred way to make a contribution is to attach a patch to a (new > or existing) issue in the Issues Database. (See > http://code.google.com/p/iui/wiki/Contributing) If a contributor makes > a series of patches that are approved and applied and demonstrates the > skills and teamwork to be an ongoing contributor to the project, we will > give that contributor SVN write access. > > Thanks, again, and I'm looking forward to reviewing your work. > > Regards, > > Sean > > > Matt Sephton wrote: >> Hello everybody, >> >> I've been using iUI for a couple of days now and have some code fixes >> and additions to help things along. >> >> It's my first time contributing to an open source project, so please >> be kind! I am a professional developer and can use SVN, so no worries >> there. I'll outline below what I've got to add, and then somebody can >> add me to the project - or not! Let me know how to proceed, basically. >> >> Code changes are referencing SVN version as of last night. >> >> + CSS change to limit li.group text to one line, adding ellipsis as required >> >> iui.css changes at line 166: >> body > ul > li.group { >> ... >> overflow: hidden; >> text-overflow: ellipsis; >> white-space: nowrap; >> } >> >> + JS change to allow otherButton (top right) on a per page basis >> this takes is cue from the undocumented hideBackButton attribute >> and uses new attributes on the page element. there may be a better >> way! >> >> <div class="toolbar"> >> <h1 id="pageTitle"></h1> >> <a id="backButton" class="button" href="#"></a> >> <a id="otherButton" class="button" href="#"></a> >> </div> >> >> <div id="password" title="Password" class="panel" >> otherButtonLabel="Done" otherButtonHref="process.php" >> otherButtonClass="blueButton"> >> ... >> </div> >> >> <ul id="thread" title="Topic" otherButtonLabel="Reply" >> otherButtonHref="reply.php"> >> ... >> </ul> >> >> iui.js change at line 326: >> var otherButton = $("otherButton"); >> if (otherButton) >> { >> var otherButtonValue = page.getAttribute("otherButtonLabel"); >> if (otherButtonValue) >> { >> otherButton.innerHTML = otherButtonValue; >> otherButton.href = page.getAttribute("otherButtonHref"); >> otherButton.className = "button "+ >> page.getAttribute("otherButtonClass"); >> otherButton.style.display = "inline"; >> } >> else >> otherButton.style.display = "none"; >> } >> >> Looking forward to your thoughts. Have a good weekend. >> >> Thanks, >> matt >> -- >> http://www.gingerbeardman.com >> >> > >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "iPhoneWebDev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/iphonewebdev?hl=en -~----------~----~----~----~------~----~------~--~---
