(fwiw I don't see anything wrong with the patch, I'm just feeling slow...)
-duncan
On 7/16/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]
> wrote:
I'm attaching my patch that does everything I needed to not get decent SOL
functionality on IPMI 2.0 systems.
-The rsp null check (which you say is already fixed in CVS, but included
because I'm too lazy to take it out)
-Rebuild the packet on retry (to increment IPMI sequence number, SOL
sequence number is, of course, left unchanged so BMC will be able to
recognize a retry if the ACK was dropped)
-Only send a retry when the session timeout has been exceeded (prevent
retries just because non-relevant data comes in)
-The output function in ipmi_sol.c validates authtype and payloadtype
before outputting.
-The timeout was decreased to one and change to increment on each retry
(my personal preference, but hardly an actual bug being fixed).
The patch was set to omit whitespace changes, so the patch contents are
easier to follow without applying. Let me know what you think.
> On 7/10/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>>
>> I'm having a few problems, two of which I put into the sourceforge bug
tracker, but if no one is paying attention there:
>> -If in SOL and a retry occurs, ipmitool 1.8.8 segfaults, because rsp is
NULL, at a particular point, the following patch seems to help:
>
>
>
> I recently fixed this (in CVS anyawy) based off some additional bug
reports. It seems that since the 1.8.8 release is broken with SOL I
should
> probably get ready for a 1.8.9 release.
>
>
>
>> -When ipmitool does successfully attempt a retry in SOL, it does not
increment the IPMI sequence number, which at least some BMC vendor says
only the SOL sequence number stays the same, and the IPMI sequence
number
>> should increase.
>
>
>
> Good question, somehow I bet every vendor does it differently but it
does seem like the IPMI sequence number should increment in the SOL
retry case. I no longer have an IPMIv2-capable board to try this on, so
I don't know if
> it will break things that work currently.
>
>
> -Sometimes data comes in that isn't SOL that is spit out like SOL data.
>> For example, the client does chassis device command and the response
sometimes fall through to the output function in ipmi_sol.c (one such
fall
>>
>> through place is confirmed as ipmi_sol.c, line 1404 in ipmitool 1.8.8.
Should output ensure data is SOL data before spitting it out or not?
>>
>>
>>
> Yes it probably should be doing something like this...
>
> -duncan
>
> -------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services,
security? Get stuff done quickly with pre-integrated technology to make
your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
> Ipmitool-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ipmitool-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Ipmitool-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
