On Thu, 24 Aug 2006 09:53:51 -0500 (07:53 PDT), Corey Minyard wrote:
> I have a set of patches that should bring forward the 2.4 driver to the
> same level of features as the 2.6 driver (as close as you can get, I
> think). I have three sets of quilt patches at:
>
> http://openipmi.sourceforge.net/patches-2.4.20.tar.gz
> http://openipmi.sourceforge.net/patches-2.4.21.tar.gz
> http://openipmi.sourceforge.net/patches-2.4.32.tar.gz
>
> These all contain the same basic things:
>
> * a "patches" directory with all the patches and a series file
> * The NMI patch
> * The v37 base patch (exactly from the sourceforge download)
> * A set of patches to add all the necessary features
> * Patches for 2.4.20 and 2.4.21 to bring them to exactly the same
> level as 2.4.32. There are some minor necessary differences with
> ACPI (ACPI is not fully cooked in 2.4.21), but that is all.
> * The SMBus patch (untested)
>
> . . .
>
> If you are interested in this, can you make sure this has all the
> features and updates you need? I've preserved the original git headers
> in the patches that came from 2.6 so you can review them.
Corey,
I took a look at these patchsets and they appear to be good, with just a
couple of minor issues. First, I encountered a compiler error when
building ipmi_kcs_intf.c that I believe was already reported on the
ipmitool-devel list earlier today by Jarrod Johnson; the extra parameter
to ipmi_register_smi() that needs to be added to a header file.
The second issue is a simple one-line patch that fixes an off-by-one bug
that causes the driver to not detect the BMC on any machine that has its
BMC as the last entry in the DMI table. This patch is not present in
these patchsets:
diff -Nurp linux-2.4.21-37.EL.orig/drivers/char/ipmi/ipmi_si.c
linux-2.4.21-37.EL/drivers/char/ipmi/ipmi_si.c
--- linux-2.4.21-37.EL.orig/drivers/char/ipmi/ipmi_si.c 2006-07-11
09:07:40.000000000 -0700
+++ linux-2.4.21-37.EL/drivers/char/ipmi/ipmi_si.c 2006-07-11
09:14:39.000000000 -0700
@@ -1668,7 +1668,7 @@ static int dmi_table(u32 base, int len,
u8 *buf;
struct dmi_header *dm;
u8 *data;
- int i=1;
+ int i=0;
int status=-1;
buf = ioremap(base, len);
Other than these two minor issues, these patchsets look great - thanks
for putting them together.
-- Roger
> Thanks,
>
> -Corey
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
