Didn't hear of any issues, into CVS it goes.

Al

On Tue, 2007-03-27 at 17:37 -0700, Al Chu wrote:
> Howdy all,
> 
> We recently hit:
> 
> ipmitool: lanplus.c:2114: ipmi_lanplus_send_payload: Assertion 
> `session->v2_data.session_state == LANPLUS_STATE_RAKP_2_RECEIVED' failed.
> Abort (core dumped)
> 
> When a bad ipmi password was used during a SOL activate w/ ipmitool
> 1.8.9.
> 
> Seems if you have a bad IPMI password, the bad HMAC returned on on rakp2
> is ignored, thus rakp 3 is sent anyways.  The sending of
> rakp3 changes the session state.  The remote BMC ignores rakp 3 (or it
> could timeout, doesn't matter either way) ipmitool resends rakp3, and
> thus we hit the assertion.
> 
> The proposed fix is to not ignore the bad HMAC.
> 
> diff -p -u -r1.58 lanplus.c
> --- src/plugins/lanplus/lanplus.c       23 Feb 2007 15:12:20 -0000      1.58
> +++ src/plugins/lanplus/lanplus.c       28 Mar 2007 00:22:27 -0000
> @@ -2962,6 +2962,7 @@ ipmi_lanplus_rakp1(struct ipmi_intf * in
>                         /* Error */
>                         lprintf(LOG_INFO, "> RAKP 2 HMAC is invalid");
>                         session->v2_data.rakp2_return_code = 
> IPMI_RAKP_STATUS_INVALID_INTEGRITY_CHECK_VALUE;
> +                        rc = 1;
>                 }
>                 else
>                 {
> 
> Al
> 
-- 
Albert Chu
[EMAIL PROTECTED]
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to