What's your feeling? Revert it or make it conditional/optional behavior
based on a flag?
~BAS
On Thu, 19 Apr 2007, James Pearson wrote:
> Brian A. Seklecki wrote:
>> Okay I'll dig through the CHANGELOG ~BAS
>>
>> On Thu, 19 Apr 2007, James Pearson wrote:
>>
>>
>>> Brian A. Seklecki wrote:
>>>
>>>> Resend -- filtered by subscriber list post only
>>>> ---
>>>>
>>>> Anyone else seeing this?
>
> Looks like the following was removed from lib/ipmi_sdr.c between 1.8.8 and
> 1.8.9 - putting it back and it works again with 1.8.9
>
> James Pearson
>
> --- ipmitool-1.8.9/lib/ipmi_sdr.c.dist 2007-03-06 22:15:37.000000000 +0000
> +++ ipmitool-1.8.9/lib/ipmi_sdr.c 2007-04-19 14:34:42.899888953 +0100
> @@ -1122,6 +1122,14 @@
> } else if (IS_SCANNING_DISABLED(rsp->data[1])) {
> /* Sensor Scanning Disabled */
> validread = 0;
> + if (rsp->data[0] != 0) {
> + /* we might still get a valid reading */
> + val =
> + sdr_convert_sensor_reading(sensor,
> + rsp->data[0]);
> + if (val != 0.0)
> + validread = 1;
> + }
> } else if (rsp->data[0] != 0) {
> /* convert RAW reading into units */
> val = sdr_convert_sensor_reading(sensor,
> rsp->data[0]);
>
l8*
-lava (Brian A. Seklecki - Pittsburgh, PA, USA)
http://www.spiritual-machines.org/
"...from back in the heady days when "helpdesk" meant nothing, "diskquota"
meant everything, and lives could be bought and sold for a couple of pages
of laser printout - and frequently were."
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Ipmitool-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
