hi,

I was using the KCS interface for some of my testing of my firmware ... 
And found that the open interface checks whether the completion code is 
0x00 and then only copies the reponse data correctly .. and if not then it 
just leaves the way it is , by this the response data recieved to the 
application side is not correct ...
In  src/plugin/open/open.c line 269
        if (rsp.ccode == 0 && rsp.data_len > 0) {
                memmove(rsp.data, rsp.data + 1, rsp.data_len);
                rsp.data[recv.msg.data_len] = 0;
        }

I was expecting to recieve completion code other that 0x00 which was valid 
in some case but this was giving a problem..
Instead of this we just need here this ..
        if (rsp.data_len > 0) {
                memmove(rsp.data, rsp.data + 1, rsp.data_len);
                rsp.data[recv.msg.data_len] = 0;
        }
Any way the upper layer always needs to check whether the completion code 
is 0x00 or not ..So i guess it should be fine here doing this ..

Thanks,
Harshad Prabhu
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to