* Audet, Jean-Michel <[EMAIL PROTECTED]> [12.09.2007 21:52]: > Not sure I understand correctly the private and native.
Under private I mean src/plugins/open/open.h header in ipmitool tree, native means /usr/include/linux/ipmi.h on Linux and /usr/include/sys/ipmi.h on FreeBSD. If You look at the beginning of src/plugins/open/open.c, You'll see that these headers are included conditinally. Inclusion of the native header causes compile to fail, because it doesn't declare transit_channel and transit_slave_addr fields in ipmi_ipmb_addr structure. > This is currently working without any modification or support from > the driver side. We just add a layer of send message and wait for > multiple answers. Thanks for the clarification! I see several ways to deal with the issue above: 1. Always use private ipmitool openipmi-like header -- bad in term of compatibility. Doesn't account for future changes in OpenIPMI. Also FreeBSD ABI is slightely different from OpenIPMI, need to account that fact. 2. Privately declare structure that has appropriate fields and use that -- same, but slightely better. 3. Integrate changes to the header file upstream -- looks best but needs some time. 4. Conditionaly use 2 or 3 above -- seems to be optimal compromise. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
