Hi, What's the current status of this patch? Is someone still working on it? Does it still need some tweaking? This functionality would be very useful to us.
Tony On Thu, Sep 13, 2007 at 03:34:53AM -0400, Thomas Rendelmann wrote: > Dmitry Frolov wrote: > > * Thomas Rendelmann <[EMAIL PROTECTED]> [12.09.2007 > > 14:25]: > > > > > Hi, > > > > > > Attached is a patch against 1.8.9 which adds Raritan specific > > > OEM commands. We added these commands to ipmitool to manage > > > our devices (e.g. firmware upgrade, read firmware version) etc. > > > We were asked by our customers to make these changes public, > > > and here is the patch for the official version. If you want, > > > you can add this to the next version of ipmitool. Our > > > customers would be happy. :-) > > > > Hi, Thomas! > > > > Vendor support is very valuable for opensource project like OpenIPMI, > > thank You for the patch! > > > > Just a couple of comments though: > > > > 1. Instead of adding another argument to ipmi_open_file() I > > would suggest > > to use something like: > > > > fp = fopen(file, "w+"); > > #ifdef WIN32 > > if (setmode(fileno(fp), O_BINARY) == -1) > > ... > > #endif > > > > This would simplify the change. > > Hi Dmitry, > > There actually was a reason for that. I compiled ipmitool for Windows, > and I realised that I had problems with file I/O because of that cr*ppy > OS. At some places in the code, files need to be opened as text files, > at some places they need to be opened as binary, and that caused > problems in Windows. That's why I added the additional argument. > > BTW, I was able to compile an older version of ipmitool (1.8.7 or 1.8.8, > don't remember) with the Visual C++ compiler. It took me quite a lot of > time to make the changes needed to make it compile (no C99, no > __attribute__((packed)), no sigsetjmp in the lan channel, SOL didn't > work at all because of the missing terminal capabilities), but in the > end, it was usable. That's the platform our OEM commands were > originally added for. > > > 2. Manpage updates are welcome too! :) > > Sorry, I forgot that. Developers always forget documentation. ;-) > > Unfortunately, I have no idea on writing manpages. I tried my very best > to do it right, but don't blame me if I did something wrong. Please > find the patch for the manpage attached. > > > Thomas > > > -- > > Thomas Rendelmann, Software Development > > Raritan Deutschland GmbH > Scheringerstr. 1, 08056 Zwickau > phone +49 375-271349-0 fax +49-375-271349-99 > USt-IdNr. DE813094160 > > Geschäftsführer/Managing Director: Gerard W. J. Heuvel > > HRB 23605 Chemnitz ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
