I commited this patch

Francois

>-----Original Message-----
>From: Tim Bell [mailto:[EMAIL PROTECTED]
>Sent: 8 novembre, 2007 06:29
>To: Isabelle, Francois
>Cc: ipmitool-devel@lists.sourceforge.net
>Subject: Re: [Ipmitool-devel] Manufacturer ID list in ipmitool compared
>toipmiutil
>
>
>
>Thanks for the pointer.
>
>Here is the patch for the ones which are in ipmiutil but not 
>in ipmitool 
>and some others that we have at CERN.
>
>If you need any further info, please get in touch.
>
>$ cvs diff -up include/ipmitool/ipmi.h lib/ipmi_strings.c
>Index: include/ipmitool/ipmi.h
>===================================================================
>RCS file: /cvsroot/ipmitool/ipmitool/include/ipmitool/ipmi.h,v
>retrieving revision 1.26
>diff -u -p -r1.26 ipmi.h
>--- include/ipmitool/ipmi.h     29 Aug 2007 05:52:15 -0000      1.26
>+++ include/ipmitool/ipmi.h     8 Nov 2007 11:27:22 -0000
>@@ -240,16 +240,31 @@ struct ipmi_rs {
> /* These values are IANA numbers */
> typedef enum IPMI_OEM {
>     IPMI_OEM_UNKNOWN    = 0,
>+    IPMI_OEM_HP         = 11,
>     IPMI_OEM_SUN        = 42,
>     IPMI_OEM_NOKIA      = 94,
>+    IPMI_OEM_HITACHI_116 = 116,
>+    IPMI_OEM_NEC        = 119,
>+    IPMI_OEM_TOSHIBA    = 186,
>     IPMI_OEM_INTEL      = 343,
>+    IPMI_OEM_TATUNG     = 373,
>+    IPMI_OEM_HITACHI_399 = 399,
>+    IPMI_OEM_DELL       = 674,
>+    IPMI_OEM_LMC        = 2168,
>     IPMI_OEM_RADISYS    = 4337,
>+    IPMI_OEM_MAGNUM     = 5593,
>     IPMI_OEM_TYAN       = 6653,
>     IPMI_OEM_NEWISYS    = 9237,
>+    IPMI_OEM_FUJITSU_SEIMENS = 10368,
>+    IPMI_OEM_AVOCENT = 10418,
>+    IPMI_OEM_PEPPERCON = 10437,
>     IPMI_OEM_SUPERMICRO = 10876,
>+    IPMI_OEM_OSA = 11102,
>     IPMI_OEM_GOOGLE       = 11129,
>     IPMI_OEM_PICMG      = 12634,
>+    IPMI_OEM_RARITAN    = 13742,
>     IPMI_OEM_KONTRON    = 15000,
>+    IPMI_OEM_AMI        = 20974,
> } IPMI_OEM;
>
> extern const struct valstr completion_code_vals[];
>Index: lib/ipmi_strings.c
>===================================================================
>RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_strings.c,v
>retrieving revision 1.25
>diff -u -p -r1.25 ipmi_strings.c
>--- lib/ipmi_strings.c  1 Oct 2007 13:59:00 -0000       1.25
>+++ lib/ipmi_strings.c  8 Nov 2007 11:27:23 -0000
>@@ -39,8 +39,10 @@
> const struct valstr ipmi_oem_info[] = {
>
>    { IPMI_OEM_UNKNOWN,    "Unknown" },
>+   { IPMI_OEM_HP,        "Hewlett-Packard" },
>    { IPMI_OEM_SUN,        "Sun Microsystems" },
>    { IPMI_OEM_INTEL,      "Intel Corporation" },
>+   { IPMI_OEM_LMC,         "LMC" },
>    { IPMI_OEM_RADISYS,    "RadiSys Corporation" },
>    { IPMI_OEM_TYAN,       "Tyan Computer Corporation" },
>    { IPMI_OEM_NEWISYS,    "Newisys" },
>@@ -49,6 +51,19 @@ const struct valstr ipmi_oem_info[] = {
>    { IPMI_OEM_KONTRON,    "Kontron" },
>    { IPMI_OEM_NOKIA,      "Nokia" },
>    { IPMI_OEM_PICMG,      "PICMG" },
>+   { IPMI_OEM_PEPPERCON,  "Peppercon AG" },
>+   { IPMI_OEM_DELL,        "DELL Inc" },
>+   { IPMI_OEM_NEC,         "NEC" },
>+   { IPMI_OEM_MAGNUM,      "Magnum Technologies" },
>+   { IPMI_OEM_FUJITSU_SEIMENS,     "Fujitsu Seimens" },
>+   { IPMI_OEM_TATUNG,      "Tatung" },
>+   { IPMI_OEM_AMI,         "AMI" },
>+   { IPMI_OEM_RARITAN,     "Raritan" },
>+   { IPMI_OEM_AVOCENT,     "Avocent" },
>+   { IPMI_OEM_OSA,         "OSA" },
>+   { IPMI_OEM_TOSHIBA,     "Toshiba" },
>+   { IPMI_OEM_HITACHI_116,         "Hitachi" },
>+   { IPMI_OEM_HITACHI_399,         "Hitachi" },
>    { 0xffff , NULL },
> };
>
>
>
>Isabelle, Francois wrote:
>> If you take the time to produce a patch, I will more than 
>happy to commit it. ;-)
>>
>> Note that the complete list 
(http://www.iana.org/assignments/enterprise-numbers)
> includes 29888 entries, so maybe we can only add the more common..
>
> Francois
>
>
>   
>> -----Original Message-----
>> From: [EMAIL PROTECTED]
>> [mailto:[EMAIL PROTECTED] Behalf Of Tim
>> Bell
>> Sent: 22 octobre, 2007 06:56
>> To: ipmitool-devel@lists.sourceforge.net
>> Subject: [Ipmitool-devel] Manufacturer ID list in ipmitool compared
>> toipmiutil
>>
>>
>>
>> The list of manufacturer codes in ipmiutil seems to be missing some 
>> which are in ipmiutil.
>>
>> >From 
>> http://ipmiutil.svn.sourceforge.net/viewvc/ipmiutil/trunk/util/
>> bmchealth.c?revision=35&view=markup, 
>> there are a much longer list than in
>> the ipmi_strings.c.
>>
>> Would it be possible to add the additional ones as standard ?
>>
>> Tim
>>
>>
>>
>> ---------------------------------------------------------------
>> ----------
>> This SF.net email is sponsored by: Splunk Inc.
>> Still grepping through log files to find problems?  Stop.
>> Now Search log events and configuration files using AJAX and a browser.
>> Download your FREE copy of Splunk now >> http://get.splunk.com/
>> _______________________________________________
>> Ipmitool-devel mailing list
>> Ipmitool-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>>
>>     

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to