Hi All, My comments about item 24).
As mentionned in chapter 5.4 "Sensor Owner Identification" of IPMI spec 2.0, the combination of Sensor owner ID and Sensor Number uniquely identify a sensor in the system. I2c address of sensor owner, of controller used to access FRU device, or of the device that generated an event, is a parameter that is necessary to know how to access a sensor or FRU; that means whether the BMC needs to bridge IPMI command or not. So, as expressed in my mails sent on 06/10/08 and 06/17/08, I think that all functions used to access sensors or FRUs should be modified like ipmi_sdr_get_sensor_reading_ipmb() in order to use the additional argument "I2c target address". Regards, Bernard > -----Message d'origine----- > De : Carol Hebert [mailto:[EMAIL PROTECTED] > Envoyé : 17 June 2008 02:11 > À : ipmitool-devel@lists.sourceforge.net > Cc : [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED] > Objet : ipmitool 1.8.10 - Fourth patch batch > > Hi, > > Here's the fourth batch of outstanding patches/issues. > Unless someone objects, review comments and feedback should > be sent within 2 weeks. > > Thank you very much for your help, :-) > > Carol > > ---------------------------------- > > > 24) On 10/31/07, Ben Bloom describes an issue he's seeing > getting sensor readings on a non-ipmb implementation. Ben, > did Holger's 11/4 workaround suggestion help? > > http://sourceforge.net/mailarchive/message.php?msg_name=BE5503 2BAC1C8441B01E9EF7CE57CC20A8EDCE%40OREXCHANGE01.radisys.com > > > 25) SEL Timestamp issue. Issue reported by Jan Parthey on > 11/23/07 and Bernard Manjou has some timestamp questions on > 4/21/08. Ajay Pandey sent an illustration of the problem on > Windows on 5/19/08: > > http://sourceforge.net/mailarchive/forum.php?forum_name=ipmito ol-devel&max_rows=25&style=nested&viewmonth=200805&viewday=19 > > > 26) Neel Chibba reports on 2/5/08 that ipmitool lan set > segfaults if all args aren't supplied (ex. ipmitool lan set 1 ipaddr) > > > My Comments: looks like this bug is still there in the > current cvs tree. > > > 27) Eric Hall writes on 2/15/08 that he'd like to have > ipmi_chassis_status() (especially) changed from a static int > to just an int function so he can use it in his ipmitool > library. His preliminary investigation indicates that there > were no namespace issues he could find. > > http://sourceforge.net/mailarchive/forum.php?forum_name=ipmito ol-devel&max_rows=25&style=nested&viewmonth=200802&viewday=15 > > > My comments: We seem to have done this for a few other > routines. I personally don't have any strong objections > about doing it for this routine. > > > 28) Ajay Pandey posts some ipmitool OEM enhancements for Dell > on 3/12/08 > > http://sourceforge.net/mailarchive/forum.php?forum_name=ipmito ol-devel&max_rows=25&style=nested&viewmonth=200803&viewday=12 > > On 4/4/08, Brian Seklecki forwarded a post indicating that > the patch is now available via ipmitool yum update: > http://sourceforge.net/mailarchive/message.php?msg_name=120752 6132.14963.57.camel%40new-host > > On 5/10/08, Subra Manuguri posted a patch that consisted of > the DEL OEM command patch as well as fixes for compilation > warnings. Subra's patch-delloem patch is uploaded to: > http://ipmitool.wiki.sourceforge.net/space/filelist > > My Comments: I have some questions/concerns about the > (original) patch, some of which are admittedly nitpicky, but > I'll list them anyway. :-} (Well, never mind the missing > header file that Subra spotted. ) Many of the new files are > not named with an ipmi_ preface. There seem to be several > files with Copyright issues. There doesn't appear to be any > man page support for the new functionality. There seems to > be a lot of code that's duplicating current functionality > (sometimes with the same names); is there a way to > modify/use the current ipmitool routines instead in some of > these cases so as to cut down on future maintenance of two > sets of similar code? > > > 29) Tomasz Nowak reports a sdr/sensor issue 4/21/08. More > info on the issue from John Philips on 5/16/08. > > http://sourceforge.net/mailarchive/forum.php?forum_name=ipmito ol-devel&max_rows=25&style=nested&viewmonth=200804&viewday=21 > > > 30) Bernard Manjou patch for i2c master write-read command > on 5/28/08: > > http://sourceforge.net/mailarchive/forum.php?forum_name=ipmito ol-devel&max_rows=25&style=nested&viewmonth=200805&viewday=28 > > > My comments: Bernard and Joshua Neal (see issue #11 in a separate > email) are in agreement on this patch. ;-) Additionally, > Joshua's reported that he tested it well, so let's get it in! :-) > > > 31) Bernard Manjou patch for returning SDR Repository Free > space (see link in #30). > > My comments: According to the spec, Bernard's fix is correct > and it should go in. > > ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
