Hi, For the third list of patches/issues I propose:
Issue Action 15) Commit patch 16) Already in the code 17) Commit patch 18) Commit patch 19) Wait a bit for more comments/concerns. 20) Wait a bit for more comments/concerns. 21) Commit patch 22) Not sure this will get addressed but it sounds oddly familiar to me ;-} 23) Fix spelling of "SEIMENS"
--- Begin Message ---Hi, Here's the third batch of outstanding patches/issues. Unless someone objects, review comments and feedback should be sent within 2 weeks. Thank you very much for your help, :-) Carol ---------------------------------- 15) Vince Worthington's 8/8/07 patch to validate user-provided sol set parameters. This patch was re-posted in response to review comments from Al Chu. http://sourceforge.net/mailarchive/message.php?msg_name=33747.172.18.101.114.1186594128.squirrel%40www.lvwnet.com My Comments: Seems like a good idea to me. Since Al reviewed the patch thoroughly already, I would suggest we include it and just make sure this area of the code gets tested thoroughly after we post our 1.8.10beta tarball for everyone to test. ('Course with SOL, that's a good idea in general. ;-) 16) Harshad Prabhu's 8/10/07 patch to ipmi_hpmfwupg.c for HPM.1 upgrade. http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200708&viewday=10 My Comments: This patch moves the "Send initiate command" stanza down a bit within in the HpmfwupgUpgradeStage() routine. Harshad, it looks like the code currently in ipmi_hpmfwupg.c has this stanza moved down even farther in the routine. I assume the current code works for you? 17) Benoit Guillon's 9/5/07 patch to fix sdr repository free space reporting: http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200709&viewday=5 My Comments: According to the spec, it appears that what's currently in the code is wrong and that Benoit's patch will fix it. 18) Harshad Prabhu's 9/12/07 lan.patch. "Patch for lan.c file related to bridged message". http://sourceforge.net/mailarchive/message.php?msg_name=OF74776770.85DDAD30-ON88257354.005C1443-88257354.006461A9%40radisys.com My comments: This patch looks interesting -- I assume its intent is to add support for IPMIv2.0/RMCP+ unauthenticated messages? Harshad, could you please send a bit more info on the patch such as whether it's fixing a problem you found, why the check for the response netfn is necessary, etc.? Also, I'm hoping some other folks with more expertise in the lan area than me will review this and send in their comments. 19) Thomas Rendelmann's 9/12/07 patch to include support for Raritan OEM commands and his 9/13/07 man page patch to go with it (yay docs! :-). (Tony Ernst sent an email on 12/07/07 asking about the status since he's interested in it too.) http://sourceforge.net/mailarchive/message.php?msg_name=9C329342B62B87498B92834DEC9FF51EC71D26%40fig.raritan.com My Comments: I tend to agree with Dmitry's patch review comments entered at the time about the patch's addition of another argument to ipmi_open_file(). Is there not another way to pass in what's needed? Anyone else have comments to share on this? 20) Harshad Prabhu's 9/18 patch to ipmi_hpmfwupg http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200709&viewday=18 My Comments: Looks like there are lots of nice formatting and output fixes in there among other things. Would want to get some review comments from some of the other HPM folks, too, since there are so many changes including some functional changes. Hopefully, we'll get some more reviewer eyes on this over the next couple of weeks. :-) 21) John Blair's 9/19/97 patch to stop ipmitool from returning a failure due to missing sensors. http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200709&viewday=19 My Comments: Yes! I and many others find the current behavior very annoying too (it's been on my personal list of things to fix for way too long). I would say (to answer your question, John), yes, please check this into cvs! :-) 22.) Tim Bell reported on 10/10/07 that a segmentation fault occurs when he runs "ipmitool sol info 1' on the Intel S5000PAL motherboards. Did anyone ever take a closer look at this issue to see what the fix might be? http://sourceforge.net/mailarchive/message.php?msg_name=470D1C9F.3050502%40cern.ch 23.) Tim Bell reports on 10/22 that there are a lot of manufacturer codes missing from ipmitool. Tim produced a patch which Francois committed. Subsequently, Steffan noticed a couple of misspellings (*SEIMENS* instead of *SIEMENS*). http://sourceforge.net/mailarchive/message.php?msg_name=471C81B3.6070006%40cern.ch Francois wanted some changes to the new patch (the one that included the spelling fixes). http://sourceforge.net/mailarchive/message.php?msg_name=C2866F9FC4CB034EB51A633DF168598602DD01CB%40ssbarcelonegb My Comments: Tim, did we ever respond to Francois' request for changes to the second (11/13/07) patch? (Either way, we at least need to fix the spelling issue for 1.8.10.)
--- End Message ---
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
