Hi,

the command line parsing as it's done in the latest ipmitool is quite
poor. There are several patches that could improve the situation a bit,
but from some reason they were not accepted:

1) 'ipmitool sel delete' should accept hexadecimal value of event id
https://sourceforge.net/mailarchive/message.php?msg_name=60f2b0dc0808161356m70895ac3l6f60a312441dc802%40mail.gmail.com

(sf.net does not show the patch to me,  I can provide it if you want).


2) 'ipmitool sol set' should check parameter ranges
https://sourceforge.net/mailarchive/forum.php?thread_name=27988.66.187.233.202.1186508444.squirrel%40www.lvwnet.com&forum_name=ipmitool-devel


3) 'ipmitool sol payload' should not crash, 'ipmitool tsol' crashes,
'sol payload enable' should check parameters
https://sourceforge.net/tracker/index.php?func=detail&aid=2186967&group_id=95200&atid=610552

This is quite new submission and I understand it can take some time to
process it.


I admit whole command line parsing in ipmitool would deserve inspection,
the above patches fix only part of the problem - but at least there are
patches. I'd volunteer to review the parsing as a whole, but to be
honest, looking at the list archives it does not motivate me to do
anything - lot of patches are left without any comments and from outside
it looks like black hole. Is there any special process how to send
patches in a way they are applied? All three above are pretty simple and
straightforward, it should not take too much time to review it and at
least provide some feedback why it's not accepted (ok, the 2nd one got
some replies, but still it's not accepted nor rejected).

Jan


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to