Hi,

It appears that the ipmitool implementation of the Platform Event
message command is missing a "1" bit in Generator ID field when the
command is sent via the system interface as per Figure 29-2 in the spec.
If you agree, I propose the following patch.  Please let me know if you
disagree or find any issues with this patch.  

Thank you very much,

Carol

---------------------------------
--- lib/ipmi_event.c.orig	2009-05-14 20:36:06.000000000 -0700
+++ lib/ipmi_event.c	2009-05-14 20:48:53.000000000 -0700
@@ -97,7 +97,7 @@
 	if (chmed == IPMI_CHANNEL_MEDIUM_SYSTEM) {
 		/* system interface, need extra generator ID */
 		req.msg.data_len = 8;
-		rqdata[0] = 0x20;
+		rqdata[0] = 0x21;  /* As per Figure 29-2, Gen ID bit 0 must == 1 */
 		memcpy(rqdata+1, emsg, sizeof(struct platform_event_msg));
 	}
 	else {
@@ -509,7 +509,7 @@
 	chmed = ipmi_current_channel_medium(intf);
 	if (chmed == IPMI_CHANNEL_MEDIUM_SYSTEM) {
 		/* system interface, need extra generator ID */
-		rqdata[0] = 0x20;
+		rqdata[0] = 0x21;  /* As per Figure 29-2, Gen ID bit 0 must == 1 */
 		req.msg.data_len = 8;
 	}
 
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to