Okay, so, it looks like all of the functions in lib/ipmi_sol.c make calls
to:
  [instance]->sendrecv


Where 'sendrcv' is actually a (bizarre looking) function mapping strcut
for src/plugins/lan/lan.c:*

So, sendrecv is actually ipmi_intf->ipmi_lan_send_cmd() ...

  Which will eventuallly call ipmi_lan_send_setup(), then
  ipmi_lan_send_open() where your your classic gethostbyname() will
  fail

   --- snipp ---
                   struct hostent *host = gethostbyname((const
                   char *)s->hostname);
                      if (host == NULL) {
                         lprintf(LOG_ERR, "Address lookup for %s failed",
                                 s->hostname);
                         return -1;


Now, "return -1" is nice, but, it doesn't help because calls to
ipmi_intf->sendrecv() are running in a loop inside a loop!

Again, we examine the error code there, but in the "default:" case, we
don't shit the bed, which I'm guessing maybe we could/should?

This I will open up to comment.  Let me put a diff out there for ya, to
get you the functionality you expect.

~BAS

On Mon, 22 Jun 2009, Fabien Wernli wrote:

> Hi,
>
> On Mon, Jun 22, 2009 at 08:10:11AM -0400, Brian A. Seklecki wrote:
> > Show it to me?  My team can review it.
>
> http://sourceforge.net/tracker/index.php?func=detail&aid=1835038&group_id=95200&atid=610550
>
> as for the memleak, I'll create one
>
>
> ------------------------------------------------------------------------------
> Are you an open source citizen? Join us for the Open Source Bridge conference!
> Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
> Need another reason to go? 24-hour hacker lounge. Register today!
> http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>

l8*
        -lava (Brian A. Seklecki - Pittsburgh, PA, USA)
               http://www.spiritual-machines.org/

    "Show me a young conservative and I'll show you someone with no heart.
    Show me an old liberal and I'll show you someone with no brains."
    ~ Winston Churchill

------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to