Saw these as I was looking through the ipmitool SEL code.
A)
evt->record_type = 0;
if (evt->record_type < 0xc0)
{
<snip>
}
else if (evt->record_type < 0xe0)
{
<snip>
}
else
{
<snip>
}
The evt->record_type is set to 0, then there is an else if statement
check for the record_type value. So there's dead code here. Probably
not what was intended.
B)
if(evt->record_type < 0xdf)
There are several of these in the file. They should be "<=" according to
the IPMI spec.
C)
if (evt->record_type == 0xf0)
{
printf (" Record Type : "
"Linux kernel panic (OEM record %02x)\n",
evt->record_type);
printf (" Panic string : %.11s\n\n",
(char *) evt + 5);
return;
}
There are several of these outputs. They appear to be a completely
arbitrary OEM special case outputs stuck in there. As far as I can
tell, there is no check for a manufacturer ID or anything to belong to
this OEM specific record. It probably should be removed unless someone
can figure out what vendor/manufacturer/product it belongs with. Or if
it belongs to some standard I'm unaware of, then at least a comment
should be added.
Al
--
Albert Chu
ch...@llnl.gov
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
