Hi all,
In the middle of this commit:
http://ipmitool.cvs.sourceforge.net/viewvc/ipmitool/ipmitool/lib/ipmi_sdr.c?r1=1.85&r2=1.86
you can see that the code redirecting from
ipmi_sdr_get_sensor_reading_ipmb() to ipmi_sdr_get_sensor_reading() for
IPMB inferfaces was commented out:
@@ -464,8 +464,8 @@ ipmi_sdr_get_sensor_reading_ipmb(struct
struct ipmi_rs *rsp;
uint8_t save_addr;
- if ((strncmp(intf->name, "ipmb", 4)) != 0)
- return ipmi_sdr_get_sensor_reading(intf, sensor);
+// if ((strncmp(intf->name, "ipmb", 4)) != 0)
+// return ipmi_sdr_get_sensor_reading(intf, sensor);
save_addr = intf->target_addr;
intf->target_addr = target;
I am no IPMI/IPMB expert by any means, but this change doesn't seem
related to the rest of the commit, and the commit description doesn't
explain it. Also, the fact that the code is commented out instead of
being just removed is suspicious. So I am curious if maybe these comment
marks were only for temporary testing/debugging purposes and weren't
meant to be committed?
I have a customer system where ipmitool 1.8.10 works and 1.8.11 hangs,
and am suspecting that the above change could be responsible for that.
Thanks,
--
Jean Delvare
Suse L3
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
