Hi, The following patch fixes an issue where ipmitool is potentially sending to much input data to the BMC with a single SOL packet. Depending on the BMC's implementation, this can lead to multiple echo's of the characters at the end, or an endless retry loop from the BMC.
Best Regards,
Holger Liebig
diff -Nur ipmitool.sav/lib/ipmi_sol.c ipmitool/lib/ipmi_sol.c
--- ipmitool.sav/lib/ipmi_sol.c 2009-01-18 14:53:12.000000000 +0100
+++ ipmitool/lib/ipmi_sol.c 2011-02-08 13:45:51.574399671 +0100
@@ -1537,6 +1537,10 @@
int keepAliveRet = 0;
int retrySol = 0;
+ /* Subtract SOL header from max_inbound_payload_size */
+ if (buffer_size > 4)
+ buffer_size -= 4;
+
buffer = (char*)malloc(buffer_size);
if (buffer == NULL) {
lprintf(LOG_ERR, "ipmitool: malloc failure");
sol.patch
Description: sol.patch
------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
