Hi, In latest plugins/lan/lan.c from CVS rev 1.66 (by audetjm) we are eliminating the sequence number to be increased when we do retry of the same command which is really helpful. But we are still adding it in the list "ipmi_req_add_entry" with the same command/sequence number so if we do retry there will be two elements in the list with the same sequence number and command number.
Ideally we don't need to add if its already added in the list. Attache is the patch for reference. Also there is one more corner case where Remote controller responds very slowly where this sequence/command check fails. The scenario is that after all the retries done it will print " Remote controller not responding" and then carry forward with the new command [the entry list will still have the command added in it]. And after that if the remote controller responds with the old command response, it will try to match from the list and will find it and match the old command response with the latest command sent. So basically we need to clean all the entries once we complete all the retries as we do not expect any response from the BMC. If there is any response from BMC then it has to be rejected. For the above corner case, consider the example where the tool sends "Get SDR" (0x23) and "Get Sensor Reading" (0x2D) . Considering that sequence number is 0x10. So it will send Get SDR and store (0x23,0x10) in the list. If it does not get response in 2 seconds it will retry and send once more the same command (with the same sequence number). And like this it will do for 4 times and then bail out. And try to send the next command (0x2D) with sequence number 0x11. Now it will add (0x2D,0x11) in the list. Now if the BMC sends response for 0x23,0x10 it will match with the list and consider its response as the response for 0x2D. We need to discard this response as its response for 0x23 and not for the latest command send ie 0x2D. To handle this case we need to clear of the list once all retries are done. I have created the patch with these modification. Let me know your feedback. Rgds Harshad
lan.patch
Description: Binary data
------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
