Hi,
In latest plugins/lan/lan.c from CVS rev 1.66 we are not increasing the sequence number when we do retry of the same command which is correct. But there is a BUG, we are still adding it in the list "ipmi_req_add_entry" with the same command/sequence number. So if we do retry there will be two elements in the list with the same sequence number and command number which should not be the case. Attached is the patch which will not add the same command/sequence in the list if its already available. Secondly, there is one more corner case where Remote controller responds very slowly where this sequence/command check fails. The scenario is that after all the retries done it will print "Remote controller not responding" and then carry forward with the new command [the entry list will still have the old command added in it]. And after that if the remote controller responds with the old command response, it will try to match from the list and will find it and match the old command response with the latest command sent. So it will take the old response for the new command which should not be the case. So we need to clean all the entries once we complete all the retries as we do not expect any response from the BMC for that command. If there is any response from BMC then it has to be rejected. A example for this corner case is added in the patch file attached. Kindly review and please add in CVS so that its available when new ipmitool is released. Rgds Harshad -- Resending it once again as my previous mail was in HTML format and not text format --
lan.patch
Description: lan.patch
------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Ciosco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
