Hi Zdenek, Please find my comments below.
>-----Original Message----- >From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] >Sent: Wednesday, December 14, 2011 5:56 PM >To: ipmitool-devel >Cc: Harshad Prabhu (hprabhu); Andy Cress >Subject: Time-out for KCS resp. open interface driver > >Hello, > >as you may have noticed, there was thread about ipmitool getting >stucked. I dug into this issue and found the problem. > >Line to blame is: >~~~ 'src/plugins/open/open.c' ~~~ > if (select(intf->fd+1, &rset, NULL, NULL, NULL) < 0) { > lperror(LOG_ERR, "I/O Error"); > return NULL; > } >~~~ 'src/plugins/open/open.c' ~~~ > That would be good if we can add some default timeout also if the user has not given any timeout. Else we will always be blocked if there is no response on that fd if the user has not provided. Like default of 2 or 5 second if the user has not provided. >Using select() here is good/wise. However select() is never going to >time-out, because time-out is set to NULL. I believe I can patch it in >the very same way, at least for time-out option, as LAN/LAN-PLUS is >patched by Harshad Prabhu. Yet, I'm wondering whether it is a good >idea to do so. Whether there is some reason why this, open driver - >KCS interface, should never ever time-out. > >Thank you for your comments. > >Regards, >Z. ------------------------------------------------------------------------------ Cloud Computing - Latest Buzzword or a Glimpse of the Future? This paper surveys cloud computing today: What are the benefits? Why are businesses embracing it? What are its payoffs and pitfalls? http://www.accelacomm.com/jaw/sdnl/114/51425149/ _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
