On Wed, Feb 8, 2012 at 5:37 PM, Jim Mank <jm...@hp.com> wrote: > All, >
Hey, > I would like to start contributing to the ipmitool project and as a > initial task I thought I would resolve the open bug associated with > ipmitool's inability to display percentage units correctly > (https://sourceforge.net/tracker/?func=detail&aid=3014014&group_id=95200&atid=610550). > I'm currently working for Hewlett Packard in their Proliant server > organization and I and others are starting to look at how we can better > serve our customers by helping make ipmitool more robust. I only have > access to HP Proliant servers, so I'll be doing my testing on various HP > Proliant servers. I'm not very familiar with IPMI so I'll be learning > as I work though problems, any and all help with IPMI would much > appreciated. > Welcome aboard. [...] > In doing these modifications, I'm wondering if it would be ok for me to > to do some local variable cleanup in ipmi_sdr_print_sensor_full. I > noticed that the local variable do_unit is set to one, but never > changed, so could this code be removed? > Sure, why not? There is a lot of work required to be done and not only in 'lib/ipmi_sdr.c'. > When I have these changes available, should I just send a patch to this > email alias? > Well, that's a question. I would and do prefer SF.net bug + ID in commit. However, I sometimes fail to do so. And it doesn't(?) make sense to do such thing for every little commit and so on. I see mailing list as a good place to ask questions and ask for opinions. My $0.02. Once again, welcome on board. Regards, Z. > -- > -- Jim Mankovich | jm...@hp.com -- > > > ------------------------------------------------------------------------------ > Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel