All,
Just to close the loop, here is the patch with the indentation changed :)
It looks to me like the indentation in this part of the file is pretty
messed up. Is it reasonable for me to fix up more indentation before I
commit this change?
-- Jim Mankovich | jm...@hp.com --
On 2/16/2012 9:43 AM, Jim Mank wrote:
Zdenek,
To answer your questions, I did test the patch and it does resolve the
problem.
I just now fixed up the indentation on the return statement.
As Andy pointed out, -t is used to specify a one byte IPMI slave address
so the parsing
of the -t argument is correct.
-- Jim Mankovich | jm...@hp.com --
On 2/16/2012 6:53 AM, Zdenek Styblik wrote:
On Wed, Feb 15, 2012 at 7:12 PM, Jim Mank<jm...@hp.com> wrote:
All,
[...]
I've attached a patch with does resolve the "Close Session command failure"
for lanplus.
Please let me know if I correctly characterized the problem and applied a
correct solution.
I don't know about this issue(without looking at it further), but
indentations in the first part of attached file are wrong :)
I presume you've tested attached patch.
btw looking at 'lib/ipmi_main.c':
---
uint8_t target_addr = 0;
[...]
case 't':
if (str2uchar(optarg,&target_addr) != 0) {
lprintf(LOG_ERR, "Invalid parameter given or out of
range for '-t'.");
rc = -1;
goto out_free;
}
break;
[...]
ipmi_main_intf->target_addr = target_addr;
[...]
---
I presume '-t' should accept either FQDN or IP address, thus lines
above are wrong, aren't they? Or is it a hex as in case of '-m'?
Thanks,
Z.
-- Jim Mankovich | jm...@hp.com --
------------------------------------------------------------------------------
Virtualization& Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Virtualization& Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
diff --git a/src/plugins/lanplus/lanplus.c b/src/plugins/lanplus/lanplus.c
index 474cbb0..ae333fe 100644
--- a/src/plugins/lanplus/lanplus.c
+++ b/src/plugins/lanplus/lanplus.c
@@ -743,8 +743,7 @@ ipmi_lan_poll_recv(struct ipmi_intf * intf)
" waiting for next answer... ");
ipmi_req_remove_entry(rsp->payload.ipmi_response.rq_seq,
rsp->payload.ipmi_response.cmd);
- ipmi_lan_poll_recv(intf);
- return;
+ return ipmi_lan_poll_recv(intf);
}
else
{
@@ -2702,6 +2701,7 @@ ipmi_close_session_cmd(struct ipmi_intf * intf)
backupBridgePossible = bridgePossible;
+ intf->target_addr = IPMI_BMC_SLAVE_ADDR;
bridgePossible = 0;
bmc_session_lsbf = intf->session->v2_data.bmc_id;
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
