One more time,
I've gotten no feedback on why the target address should not be set for non
ipmb interfaces. I believe this
code is incorrect whenever a sensor to be read is not identified in the SDR as
residing on the IPMB. I verified
that this is indeed the case, any sensor with a Sensor Owner ID not equal to
0x20 cannot be read if the interface
target address is not correctly set to the Sensor Owner ID from the SDR.
I believe this if statement should be removed for good from
ipmi_sdr_get_sesnor_reading_ipmb. The function
ipmi_sdr_get_sensor_reading can be removed as well since this is the only code
that calls the function.
-- Jim Mankovich | jm...@hp.com --
On 2/24/2012 7:42 AM, Jim Mankovich wrote:
> Hello again,
>
> Can someone explain why the ipmi_sdr_get_sensor_reading_ipmb routine doesn't
> to set
> the target_addr when not on the "ipmb" interface?
>
> I've been testing over lanplus and I found that any sensor with a target
> address not equal
> to the IPMI_BMC_SLAVE_ADDR is not readable with the TOB version, but it can
> be read with
> version 1.8.11.dell19. I tracked the inconsistency between the versions
> down to the fact
> that following if statement was re-enabled in version 1.96 of ipmi_sdr.c.
> The commit comment
> for this change doesn't really explain in detail why this change was made.
>
> struct ipmi_rs *
> ipmi_sdr_get_sensor_reading_ipmb(struct ipmi_intf *intf, uint8_t sensor,
> uint8_t target, uint8_t lun, uint8_t channel)
> {
> ..
> if ((strncmp(intf->name, "ipmb", 4)) != 0)
> return ipmi_sdr_get_sensor_reading(intf, sensor);
> ...
> return rsp;
> }
>
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
