Hello all,
I gave it some thought, and since IPMI specification is quite exact what
range of UIDs is allowed, it seems to be as a good idea to put in more
limitations what could and should be accepted as a "valid" UID. In other
words, what's missing from 'lib/ipmi_user.c' are couple of ``if (uid >
63)''.
Only con I can think of is a] IPMI implementation that violates IPMI spec
b] a new spec which would allow UIDs > 63, although this seems unlikely.
And since it is noted even in source code itself, I see no problem to
"expand" the limits when such time comes.
Come to think of it, how about implementation as:
~~~
#define UID_MIN 1
#define UID_MAX 63
[...]
some_function()
{
[...]
if (uid < UID_MIN || uid > UID_MAX) {
/* error */
}
[...]
}
~~~
Regards,
Duncan
------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
