From b6f4a0814d46f20c716d2e3fcd151b187a0c56d6 Mon Sep 17 00:00:00 2001 From: Duncan Idaho Date: Fri, 20 Apr 2012 18:24:18 +0200 Subject: [PATCH 4/7] lib/ipmi_lanp.c - add comment about password reset Signed-off-by: Duncan Idaho Commit adds handy comment into function ipmi_lan_set(). When NULL pointer is passed to ipmi_lan_set_password(), then password is cleared. Comment is supposed to be explanatory why line below is written the way it is. --- lib/ipmi_lanp.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/ipmi_lanp.c b/lib/ipmi_lanp.c index 147932a..b14d783 100644 --- a/lib/ipmi_lanp.c +++ b/lib/ipmi_lanp.c @@ -459,7 +459,7 @@ lan_set_arp_interval(struct ipmi_intf * intf, uint8_t chan, uint8_t * ival) { struct lan_param *lp; - uint8_t interval; + uint8_t interval = 0; int rc = 0; lp = get_lan_param(intf, chan, IPMI_LANP_GRAT_ARP); @@ -1544,6 +1544,7 @@ ipmi_lan_set(struct ipmi_intf * intf, int argc, char ** argv) /* session password * not strictly a lan setting, but its used for lan connections */ else if (strncmp(argv[1], "password", 8) == 0) { + /* if argv[2] equals NULL, then clear password */ rc = ipmi_lan_set_password(intf, 1, (uint8_t *)argv[2]); } /* snmp community string */ -- 1.7.4.4