Jim, I've tested get_cmdline_*() functions(PATCH 11 and 12) when trying to put some limits in. I'm fairly sure I've tested lan_set_arp_interval() at some point(,[PATCH 09/12]) but if somebody is going to re-test it, even better. I haven't tested adding those intf checks([PATCH 03/12]) thoroughly, resp. further than compiler. They're a bit paranoid, to be honest.
Thanks, --Duncan On Tue, Apr 24, 2012 at 5:50 PM, Jim Mankovich <jm...@hp.com> wrote: > Duncan, > > I reviewed these changes and they look good. > > Did you test all these changes? > > -- Jim Mankovich | jm...@hp.com -- > > On 4/22/2012 4:01 AM, Duncan Idaho wrote: > > On Fri, Apr 20, 2012 at 9:55 PM, Duncan Idaho <dune.id...@gmail.com> wrote: >> >> Hello, >> >> here is set of proposed changes to 'lib/ipmi_lanp.c'. This set is nowhere >> near finite, but earlier the review, better. >> >> Thanks for comments, >> --Duncan > > > Second batch of proposed changes. > > --Duncan > > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > > > > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
