Renzo,

This change looks good to me. I'll apply the change to CVS repository unless 
someone has an
issue with it.

-- Jim Mankovich | jm...@hp.com --


On 5/29/2012 1:12 PM, Hayashi, Renzo wrote:

I have identified a bug in IPMI Tool and have subsequently created a patch for 
it.  I would like to apply for this fix/patch.

Issue:

When using the "ipmitool fru" command, one of the fields displayed is the "Board Mfg 
Date".  This date is computed by taking the timestamp in the FRU, which is based off of 1/1/1996 0:0:0 
and adding the delta time from 1/1/1970 0:0:0 to 1/1/1996 0:0:0 so that it can be interpreted by Linux time.  
This delta time is a hard-coded constant in ipmi_fru.h (secs_from_1970_1996).  This constant is incorrect.  
Currently it is set to 820450800.  The correct delta from those two dates should be 820454400.  This is 
resulting in a "Board Mfg Date" that is actually 1 hour earlier than what it should be.  The patch 
corrects this constant in ipmi_fru.h.

I've attached the patch for this (for the latest ipmitool-1.8.11) to this 
email.  I am requesting approval for this fix.  Please advise me on how to 
proceed.

Thank you,

Renzo Hayashi

Intel Corporation



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to