Hank,
are we talking about the same patch which is:
~~~
commit 00576a015de3aacd8326b0a5641d0db331b588e6
Author: Jan Safranek <jsafr...@redhat.com>
Date: Mon Aug 13 14:35:28 2012 +0200
Fixed ipmievd start under systemd.
Systemd init system starts services with parent PID=1. Still, it is expected
that the daemon forks and exits with nozero exit status, if its
initialization
fails.
diff --git a/lib/helper.c b/lib/helper.c
index 9db693a..bc9fa84 100644
--- a/lib/helper.c
+++ b/lib/helper.c
@@ -549,10 +549,6 @@ ipmi_start_daemon(struct ipmi_intf *intf)
sigset_t sighup;
#endif
- /* if we are started from init no need to become daemon */
- if (getppid() == 1)
- return;
-
#ifdef SIGHUP
sigemptyset(&sighup);
sigaddset(&sighup, SIGHUP);
~~~
?
I'd say Jan is referring to later while you're referring to former,
original, patch Jan proposed.
Regards,
Z.
On Tue, Sep 4, 2012 at 11:38 AM, Hank Bruning <h...@jblade.com> wrote:
> Ok, so the patch is a low level thing and should be accepted.
> I'm guessing, correct me if I'm wrong, the higher level software that you
> have no control over will increase packet RMCP packet rates, not to the
> level of PICMG HPM.2 but this change allows for a few percent faster rates
> ?
> Hank
>
>
> On Tue, Sep 4, 2012 at 3:16 AM, Jan Safranek <jsafr...@redhat.com> wrote:
>>
>> Hank,
>>
>> I am not sure I understand the question. The patch has nothing to do
>> with any packet rate. It only ensures that ipmievd forks properly on
>> systems with systemd.
>>
>> Jan
>>
>> On 09/03/2012 08:47 PM, Hank Bruning wrote:
>> > Jan,
>> > What does this do to the IPMI UPD packet rate ? Increase or decrees ?
>> > Don't do the patch till he answers.
>> > Hank Bruning
>> > President
>> > JBlade
>> >
>> > On Mon, Sep 3, 2012 at 7:16 AM, Jan Safranek <jsafr...@redhat.com
>> > <mailto:jsafr...@redhat.com>> wrote:
>> >
>> > I understand it as nobody is starting ipmevd directly from PID=1
>> > except
>> > systemd and therefore the patch does not break anything I know of
>> > and
>> > helps systemd-based distros.
>> >
>> > Anyway, there is 'nodaemon' option for those who don't want to fork.
>> >
>> > Is there any other reason for this patch not being accepted?
>> >
>> > Jan
>> >
>> > On 08/13/2012 05:44 PM, Jim Mankovich wrote:
>> > > Jan,
>> > > I was reporting what read in the man pages for init on my Ubuntu
>> > 11.10
>> > > installation. I don't know that anyone would have a good reason
>> > for starting
>> > > ipmievd directly from init (via a script in /etc/init).
>> > >
>> > > -- Jim Mankovich | jm...@hp.com <mailto:jm...@hp.com> --
>> > >
>> > > On 8/13/2012 9:27 AM, Jan Safranek wrote:
>> > >> On 08/13/2012 05:07 PM, Jim Mankovich wrote:
>> > >>> Jan,
>> > >>>
>> > >>> In looking at the man pages for init, init(5) in particular,
>> > there is an
>> > >>> init script option
>> > >>> "expect fork" which you must use if the job's main process will
>> > >>> fork. So, if anyone is
>> > >>> using an init script to start up ipmievd today your change will
>> > require
>> > >>> them to change
>> > >>> their init script to use "expect fork". Otherwise, init won't
>> > be
>> > >>> monitoring the correct
>> > >>> process and the current init script won't work correctly.
>> > >> What init is it? From the description it looks like upstart. Does
>> > anyone
>> > >> uses ipmievd as upstart job? I don't have much experience with
>> > it. Even
>> > >> Ubuntu still ships ipmievd init script, i.e. ipmievd is started
>> > via init
>> > >> script /etc/init.d/ipmievd, which won't run under PID=1.
>> > >>
>> > >> Jan
>> > >>
>> > >>> -- Jim Mankovich | j...@hp.com <mailto:j...@hp.com> |
>> > 303-440-4047 (MST) --
>> > >>>
>> > >>> On 8/13/2012 6:44 AM, Jan Safranek wrote:
>> > >>>> Hi,
>> > >>>>
>> > >>>> instead of adding systemd code to ipmitool, I tried to find out
>> > what is
>> > >>>> really wrong with impievd so systemd cannot start it. It's
>> > quite
>> > >>>> difficult to debug systemd and a daemon together, but finally I
>> > got results.
>> > >>>>
>> > >>>> It turns out that the ipmievd does not fork() at all if it is
>> > started
>> > >>>> under PID=1. That was the last thing I would expect :), that's
>> > why it
>> > >>>> took so much time, I was looking for bugs elsewhere.
>> > >>>>
>> > >>>> Attached you can find another patch, now it's very simple and
>> > without
>> > >>>> any copyright notices.
>> > >>>>
>> > >>>> Is there any other init system, which starts service with
>> > parent PID=1?
>> > >>>> I.e. does the patch break anything?
>> > >>>>
>> > >>>> Jan
>> > >>>>
>> > >>>>
>> > >>>>
>> > >>>>
>> >
>> > ------------------------------------------------------------------------------
>> > >>>> Live Security Virtual Conference
>> > >>>> Exclusive live event will cover all the ways today's security
>> > and
>> > >>>> threat landscape has changed and how IT managers can respond.
>> > Discussions
>> > >>>> will include endpoint security, mobile security and the latest
>> > in malware
>> > >>>> threats.
>> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> > >>>>
>> > >>>>
>> > >>>> _______________________________________________
>> > >>>> Ipmitool-devel mailing list
>> > >>>> Ipmitool-devel@lists.sourceforge.net
>> > <mailto:Ipmitool-devel@lists.sourceforge.net>
>> > >>>> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>> > >>
>> > >>
>> >
>> > ------------------------------------------------------------------------------
>> > >> Live Security Virtual Conference
>> > >> Exclusive live event will cover all the ways today's security and
>> > >> threat landscape has changed and how IT managers can respond.
>> > Discussions
>> > >> will include endpoint security, mobile security and the latest in
>> > malware
>> > >> threats.
>> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> > >> _______________________________________________
>> > >> Ipmitool-devel mailing list
>> > >> Ipmitool-devel@lists.sourceforge.net
>> > <mailto:Ipmitool-devel@lists.sourceforge.net>
>> > >> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>> > >>
>> > >
>> > >
>> > >
>> >
>> > ------------------------------------------------------------------------------
>> > > Live Security Virtual Conference
>> > > Exclusive live event will cover all the ways today's security and
>> > > threat landscape has changed and how IT managers can respond.
>> > Discussions
>> > > will include endpoint security, mobile security and the latest in
>> > malware
>> > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> > > _______________________________________________
>> > > Ipmitool-devel mailing list
>> > > Ipmitool-devel@lists.sourceforge.net
>> > <mailto:Ipmitool-devel@lists.sourceforge.net>
>> > > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>> > >
>> >
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > Live Security Virtual Conference
>> > Exclusive live event will cover all the ways today's security and
>> > threat landscape has changed and how IT managers can respond.
>> > Discussions
>> > will include endpoint security, mobile security and the latest in
>> > malware
>> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> > _______________________________________________
>> > Ipmitool-devel mailing list
>> > Ipmitool-devel@lists.sourceforge.net
>> > <mailto:Ipmitool-devel@lists.sourceforge.net>
>> > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>> >
>> >
>>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
