Corey,
These changes look good and seem ok for providing the ability to set the
instance for an SOL session.
The only improvement might be to create a function to parse out the "instance-"
for activate/deactivate
since the code is same for both cases.
I am curious as to how you were able to create an SOL session via ipmitool with
an instance not equal
to one prior to your changes. You mention below that "there may be times when
the instance is not
one", but from my read of the current code, this should never be the case since
ipmitool SOL activate
always specifies and instance of one when activating an SOL session.
-- Jim Mankovich | jm...@hp.com --
On 9/12/2012 1:09 PM, Corey Minyard wrote:
The activate payload takes and instance, and there may be times when the
instance is not one. Is this patch acceptable for setting the instance for SOL
sessions?
Thanks,
-corey
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
